watch verification test script gives false positive

[amitkrout]

/kind bug

What versions of software are you using?

Operating System:
Supported
Output of odo version:
master

How did you run odo exactly?

https://github.com/openshift/odo/blob/master/tests/e2escenarios/e2e_images_test.go#L96

Actual behavior

watch verification test code https://github.com/openshift/odo/blob/master/tests/integration/devfile/utils/utils.go#L212 gives false positive.

For more details check - #3307 (comment)

Expected behavior

Should capture actual failure incase the watch command hits any flake.

Any logs, error output, etc?

[odo]  ✓  Changes successfully pushed to component
[odo] I0605 10:40:00.637281   12694 odo.go:72] Could not get the latest release information in time. Never mind, exiting gracefully :)
Checking http://nodejs-app-8080-app-asmsndmfgf.apps.ci-op-krjbpspq-25553.origin-ci-int-aws.dev.rhcloud.com, for Hello nodejs UPDATED
try 0 of 90
Running curl with args [curl http://nodejs-app-8080-app-asmsndmfgf.apps.ci-op-krjbpspq-25553.origin-ci-int-aws.dev.rhcloud.com]
Deleting dir: /tmp/848937215/abcd
Replacing "Hello" with "Hello odo" in /tmp/848937215/server.js
[curl]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[curl]                                  Dload  Upload   Total   Spent    Left  Speed
[curl] 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    42    0    42    0     0    171      0 --:--:-- --:--:-- --:--:--   172
[curl] Hello nodejs UPDATED world from node.js!
[curl] 
Running curl with args [curl http://nodejs-app-8080-app-asmsndmfgf.apps.ci-op-krjbpspq-25553.origin-ci-int-aws.dev.rhcloud.com]
[curl]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[curl]                                  Dload  Upload   Total   Spent    Left  Speed
[curl] 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    42    0    42    0     0    180      0 --:--:-- --:--:-- --:--:--   181
[curl] Hello nodejs UPDATED world from node.js!
[curl] 
Running curl with args [curl http://nodejs-app-8080-app-asmsndmfgf.apps.ci-op-krjbpspq-25553.origin-ci-int-aws.dev.rhcloud.com]
[curl]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[curl]                                  Dload  Upload   Total   Spent    Left  Speed
[curl] 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    42    0    42    0     0    174      0 --:--:-- --:--:-- --:--:--   175
[curl] Hello nodejs UPDATED world from node.js!
[curl] 
Running curl with args [curl http://nodejs-app-8080-app-asmsndmfgf.apps.ci-op-krjbpspq-25553.origin-ci-int-aws.dev.rhcloud.com]
[curl]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[curl]                                  Dload  Upload   Total   Spent    Left  Speed
[curl] 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0Hello nodejs UPDATED world from node.js!
[curl] 
[curl] 
1
[...]
[curl] Hello nodejs UPDATED world from node.js!
[curl] 
Deleting project: asmsndmfgf
Running odo with args [odo project delete asmsndmfgf -f]
[odo] This project contains the following applications, which will be deleted
[odo] Application app
[odo] I0605 10:45:01.846787   12787 application.go:49] Unable to list Service Catalog instances: unable to list ServiceInstances: serviceinstances.servicecatalog.k8s.io is forbidden: User "developer" cannot list resource "serviceinstances" in API group "servicecatalog.k8s.io" in the namespace "asmsndmfgf"
[odo] I0605 10:45:02.112243   12787 occlient.go:2825] Getting DeploymentConfig: nodejs-app-app
[odo] I0605 10:45:02.210967   12787 component.go:987] Source for component nodejs-app is  (local)
[odo] I0605 10:45:02.211015   12787 url.go:349] Listing routes with label selector: app.kubernetes.io/part-of=app,app.kubernetes.io/instance=nodejs-app
[odo] I0605 10:45:02.211032   12787 occlient.go:2684] Listing routes with label selector: app.kubernetes.io/part-of=app,app.kubernetes.io/instance=nodejs-app
[odo] I0605 10:45:02.300168   12787 preference.go:188] The path for preference file is /tmp/848937215/config.yaml
[odo] I0605 10:45:02.473043   12787 occlient.go:2825] Getting DeploymentConfig: nodejs-app-app
[odo] This application has following components that will be deleted
[odo] I0605 10:45:02.734690   12787 occlient.go:2825] Getting DeploymentConfig: nodejs-app-app
[odo] I0605 10:45:02.821890   12787 component.go:987] Source for component nodejs-app is  (local)
[odo] I0605 10:45:02.821922   12787 url.go:349] Listing routes with label selector: app.kubernetes.io/part-of=app,app.kubernetes.io/instance=nodejs-app
[odo] I0605 10:45:02.821929   12787 occlient.go:2684] Listing routes with label selector: app.kubernetes.io/part-of=app,app.kubernetes.io/instance=nodejs-app
[odo] I0605 10:45:02.909277   12787 preference.go:188] The path for preference file is /tmp/848937215/config.yaml
[odo] I0605 10:45:03.081075   12787 occlient.go:2825] Getting DeploymentConfig: nodejs-app-app
[odo] I0605 10:45:03.254539   12787 url.go:349] Listing routes with label selector: app.kubernetes.io/part-of=app,app.kubernetes.io/instance=nodejs-app
[odo] I0605 10:45:03.254551   12787 occlient.go:2684] Listing routes with label selector: app.kubernetes.io/part-of=app,app.kubernetes.io/instance=nodejs-app
[odo] component named nodejs-app
[odo] This component has following urls that will be deleted with component
[odo] URL named nodejs-app-8080 with host nodejs-app-8080-app-asmsndmfgf.apps.ci-op-krjbpspq-25553.origin-ci-int-aws.dev.rhcloud.com having protocol http at port 8080
[odo] I0605 10:45:03.344735   12787 preference.go:188] The path for preference file is /tmp/848937215/config.yaml
[odo] I0605 10:45:03.430555   12787 project.go:136] unable to list services: unable to list ServiceInstances: serviceinstances.servicecatalog.k8s.io is forbidden: User "developer" cannot list resource "serviceinstances" in API group "servicecatalog.k8s.io" in the namespace "asmsndmfgf"
[odo] No services / could not get services
[odo]  ⚠  Warning! Projects are deleted from the cluster asynchronously. Odo does its best to delete the project. Due to multi-tenant clusters, the project may still exist on a different node.
[odo] I0605 10:45:03.522776   12787 odo.go:72] Could not get the latest release information in time. Never mind, exiting gracefully :)
[odo]  ✓  Deleted project : asmsndmfgf
Deleting dir: /tmp/848937215
• Failure [373.968 seconds]
odo supported images e2e tests
/go/src/github.com/openshift/odo/tests/e2escenarios/e2e_images_test.go:14
  odo supported images deployment
  /go/src/github.com/openshift/odo/tests/e2escenarios/e2e_images_test.go:83
    Should be able to verify the nodejs-8-centos7 image [It]
    /go/src/github.com/openshift/odo/tests/e2escenarios/e2e_images_test.go:119
    Timeout out after � minutes
    /go/src/github.com/openshift/odo/tests/helper/helper_generic.go:149 

[amitkrout]

It has been fixed as part of pr #3457. In CI the flake is now time out in watch ticker instead of culr error.

Reference - https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/3462/pull-ci-openshift-odo-master-v4.3-integration-e2e/1280067878812389376#1:build-log.txt%3A648

/close

[openshift-ci-robot]

@amitkrout: Closing this issue.

In response to this:

It has been fixed as part of pr #3457. In CI the flake is now time out in watch ticker instead of culr error.

Reference - https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/3462/pull-ci-openshift-odo-master-v4.3-integration-e2e/1280067878812389376#1:build-log.txt%3A648

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.