[duplicate] odo watch deletes all files

[amitkrout]

/kind bug

What versions of software are you using?

Operating System:
CI
Output of odo version:
master

How did you run odo exactly?

#3307 (comment)

Actual behavior

watch stuck

Expected behavior

watch should push the changes

Any logs, error output, etc?

[amitkrout]

It seems the issue is with pushing files steps

$ odo watch nodejs-app --context tests/examples/source/nodejs/
[...]
Pushing files...
 ✓  Waiting for component to start [629ms]
 ✓  Syncing files to the component [4s]
 ✓  Building component [5s]
[...]

I think it stuck in any one of these steps may be in the step Waiting for component to start or Building component. I need to figure out if this is the case then why the function WatchNonRetCmdStdOut does not throw any error.

Cluster load increases with consistently pushing and build files due to the multiple changes (file/dir create , delete and update in server.js file) in the context dir causing the issue. Just to confirm it i am going to keep the server.js file change in the first place for watch command.

EDIT: It worked, i mean route successfully hit the application end point by keeping the server.js file change in the first place for watch command verification.

[dharmit]

To be split into two. @amitkrout to open another issue where we'll need dev inputs.

[kadel]

@amitkrout Can you please provide steps how it can be reproduced outside of our tests?

[amitkrout]

@amitkrout Can you please provide steps how it can be reproduced outside of our tests?

@kadel
Steps to reproduce:

$ odo project create test123

$ oc --request-timeout 5m import-image nodejs --namespace=test123 --from=registry.access.redhat.com/rhscl/nodejs-10-rhel7:latest --confirm

$ oc annotate istag/nodejs:latest --namespace=test123 tags=builder --overwrite

$ odo create nodejs nodejs-app --project test123 --context tests/examples/source/nodejs/

$ odo push --context tests/examples/source/nodejs/

$ odo url create --port 8080 --context tests/examples/source/nodejs/

$ odo push --context tests/examples/source/nodejs/

$ curl -ik http://nodejs-app-8080-app-test123.apps.gamore46installer25thjune.devcluster.openshift.com
// Hello world from node.js! 

// Update the message in the file https://github.com/openshift/odo/blob/master/tests/examples/source/nodejs/server.js#L12

$ odo push --context tests/examples/source/nodejs/

$ curl -ik http://nodejs-app-8080-app-test123.apps.gamore46installer25thjune.devcluster.openshift.com
// Should display the updated message 

Create a shell script check.sh and put it in the context dir tests/examples/source/nodejs/
$ cat check.sh 
#!/bin/sh

# fail if some commands fails
set -e
# show commands
set -x

touch {a..z}.txt
sleep 3
rm {a..z}.txt
mkdir {1...9}
rm -rf {1...9}
sed -i "" "s/Hello/Hello 1/g" server.js

$ odo watch nodejs-app --context tests/examples/source/nodejs/

// open another terminal. Go to the context dir and run check.sh from there
$ ./check.sh

// Keep executing the shell script more than once or so, you will hit the issue, I mean watch will stuck 

Waiting for something to change in /Users/amit/go/src/github.com/openshift/odo/tests/examples/source/nodejs
Pushing files...
 ✓  Waiting for component to start [355ms]
 ✓  Syncing files to the component [7s]
 ✓  Building component [4s]
Waiting for something to change in /Users/amit/go/src/github.com/openshift/odo/tests/examples/source/nodejs
File . changed
File /Users/amit/go/src/github.com/openshift/odo/tests/examples/source/nodejs/server.js changed
Pushing files...
 ✓  Waiting for component to start [331ms]
 ◓  Syncing files to the component

So this output confirms that the issue is with watch command itself.

Then what is the issue with the test script:

Timeout is happening while curling for a particular text instead of watch command. This is happening because watch command fails to capture the actual failure due to faulty script https://github.com/openshift/odo/blob/master/tests/integration/devfile/utils/utils.go#L212. The fault lies in the go routine, actually we are not handling buffer output efficiently for each change in the source. Asper our current code it looks in the buffer for a string Waiting for something to change and it does not even bother if very next file changes push stuck or fails.

[amitkrout]

Issue #3420 created for watch verification test script refactor