Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Grammar for odo Error for Project Create and Set #2255

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Fix Grammar for odo Error for Project Create and Set #2255

merged 1 commit into from
Oct 9, 2019

Conversation

danielhelfand
Copy link
Contributor

@danielhelfand danielhelfand commented Oct 7, 2019

What is the purpose of this change? What does it change?

Changes the error message grammar for odo project create and odo project set.

Was the change discussed in an issue?

Closes #2254

@openshift-ci-robot
Copy link
Collaborator

Hi @danielhelfand. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. size/XS labels Oct 7, 2019
@danielhelfand danielhelfand changed the title Fix Grammar for odo Error for Project Create and Delete Fix Grammar for odo Error for Project Create and Set Oct 7, 2019
@kadel
Copy link
Member

kadel commented Oct 8, 2019

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 8, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Oct 8, 2019
@cdrage
Copy link
Member

cdrage commented Oct 8, 2019

/retest

@danielhelfand
Copy link
Contributor Author

@cdrage Not sure how much this is a factor in tests, but should needs-ok-to-test label be added? Otherwise, will keep an eye on it and /retest.

@danielhelfand
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Collaborator

@danielhelfand: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cdrage
Copy link
Member

cdrage commented Oct 8, 2019

Yeah, CI is flaking..

/retest

@kadel
Copy link
Member

kadel commented Oct 9, 2019

/retest

CI issue

Lease acquired, installing...
level=fatal msg="failed to fetch Terraform Variables: failed to fetch dependency of \"Terraform Variables\": failed to fetch dependency of \"Bootstrap Ignition Config\": failed to fetch dependency of \"Master Machines\": failed to generate asset \"Platform Credentials Check\": validate AWS credentials: mint credentials check: error simulating policy: Throttling: Rate exceeded\n\tstatus code: 400, request id: 48e3ec24-ea0a-11e9-bba2-111df2ad0ed5"
2019/10/08 20:29:11 Container setup in pod e2e-scenarios failed, exit code 1, reason Error
Another process exited

@openshift-merge-robot openshift-merge-robot merged commit 9318bc1 into redhat-developer:master Oct 9, 2019
@rm3l rm3l added the estimated-size/XS (1-5) Rough sizing for Epics. Less than one sprint of work for one person, but smaller than S. label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. estimated-size/XS (1-5) Rough sizing for Epics. Less than one sprint of work for one person, but smaller than S. lgtm Indicates that a PR is ready to be merged. Required by Prow. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grammar incorrect for "odo create" project creation
6 participants