Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix links to google group #2475

Merged
merged 1 commit into from Dec 18, 2019
Merged

Conversation

@maxandersen
Copy link
Contributor

maxandersen commented Dec 18, 2019

had to escape the # in url to make it actually work.

/kind documentation

had to escape the # in url to make it actually work.
@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Dec 18, 2019

Hi @maxandersen. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mohammedzee1000

This comment has been minimized.

Copy link
Collaborator

mohammedzee1000 commented Dec 18, 2019

/ok-to-test

@mohammedzee1000

This comment has been minimized.

Copy link
Collaborator

mohammedzee1000 commented Dec 18, 2019

/kind documentation

@kadel

This comment has been minimized.

Copy link
Member

kadel commented Dec 18, 2019

thank you @maxandersen
/approve
/lgtm
/retest

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Dec 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -63,7 +63,7 @@ https://asciinema.org/a/wVkVgUrO7PGR5CYBFbHB5fFDn[image:https://asciinema.org/a/

*Chat:* Join us on link:https://join.slack.com/t/openshiftdo/shared_invite/enQtODUwMjIzMzE2MjYyLWM3YjlkNTViOGNjZGQ5YjFlMzc2N2RhZjVmMDQ5NWY5ZDQ3NzMzZjYxMTE1MjY5OTVmZjgxZWMyMGRmOTc4Y2I[Slack].

*Discussions:* For any developmental discussions with `odo`, use our link:https://groups.google.com/forum/#!forum/odo-dev[odo-dev Google group], for general help and inquiries, join our link:https://groups.google.com/forum/#!forum/odo-users[odo-users Google group].
*Discussions:* For any developmental discussions with `odo`, use our link:https://groups.google.com/forum/\#!forum/odo-dev[odo-dev Google group], for general help and inquiries, join our link:https://groups.google.com/forum/\#!forum/odo-users[odo-users Google group].

This comment has been minimized.

Copy link
@cdrage

cdrage Dec 18, 2019

Collaborator

This is really really odd.. First link works, second link doesn't, even though they're the exact same. GitHub asciidoc bug perhaps?

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 18, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 18, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 18, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 528a75c into openshift:master Dec 18, 2019
6 checks passed
6 checks passed
Travis CI - Pull Request Build Passed
Details
ci/prow/unit Job succeeded.
Details
ci/prow/v4.1-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.2-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.3-integration-e2e-benchmark Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.