Fixing app delete flake in service test file #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
kind/bug
|
ping @mik-dass |
|
pr #2767 |
amitkrout
force-pushed
the
fixingAppDeleteFlake
branch
from
1ef5966
to
8cf05ba
Compare
Codecov Report
@@ Coverage Diff @@
## master #2767 +/- ##
==========================================
- Coverage 43.58% 43.56% -0.03%
==========================================
Files 91 91
Lines 8266 8266
==========================================
- Hits 3603 3601 -2
- Misses 4314 4315 +1
- Partials 349 350 +1
Continue to review full report at Codecov.
|
mohammedzee1000
approved these changes
Mar 27, 2020
openshift-ci-robot
added
the
lgtm
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel, prietyc123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does does this PR do / why we need it:
Due to parallel run race condition arises when spec selects the active project. Such flake is fixed in this pr.
Which issue(s) this PR fixes:
Fixes #2765
How to test changes / Special notes to the reviewer:
make test-cmd-service