Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing e2e image test flake #2768

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Fixing e2e image test flake #2768

merged 1 commit into from
Apr 3, 2020

Conversation

amitkrout
Copy link
Contributor

@amitkrout amitkrout commented Mar 27, 2020 •
edited

What type of PR is this?
/kind flake

What does does this PR do / why we need it:
Flake fix
Which issue(s) this PR fixes:

Fixes #2641

How to test changes / Special notes to the reviewer:
e2e image validation should pass in OpenShift CI and locally too

@openshift-ci-robot openshift-ci-robot added the flake Categorizes issue or PR as related to a flaky test. label Mar 27, 2020
@amitkrout amitkrout mentioned this pull request Mar 27, 2020
Closed
@amitkrout
Copy link
Contributor Author

pr #2767 fixes travis flake

@codecov
Copy link

codecov bot commented Mar 27, 2020 •
edited

Codecov Report

Merging #2768 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2768   +/-   ##
=======================================
  Coverage   43.39%   43.39%           
=======================================
  Files          91       91           
  Lines        8312     8312           
=======================================
  Hits         3607     3607           
  Misses       4352     4352           
  Partials      353      353

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 791be7f...e68011b. Read the comment docs.

@amitkrout
Copy link
Contributor Author

#2642
/retest

@prietyc123
Copy link
Contributor

Look good to me 👍

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 30, 2020
@girishramnani
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Mar 30, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@amitkrout
Copy link
Contributor Author

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/2768/pull-ci-openshift-odo-master-v4.3-integration-e2e-benchmark/1447#1:build-log.txt%3A445
/test v4.3-integration-e2e-benchmark

@amitkrout
Copy link
Contributor Author

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/2768/pull-ci-openshift-odo-master-v4.2-integration-e2e-benchmark/1405#1:build-log.txt%3A433
/test v4.2-integration-e2e-benchmark

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@mik-dass
Copy link
Contributor

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/2768/pull-ci-openshift-odo-master-v4.2-integration-e2e-benchmark/1422#1:build-log.txt%3A886

Doesn't seem to fix the problem.
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Mar 30, 2020
@amitkrout
Copy link
Contributor Author

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/2768/pull-ci-openshift-odo-master-v4.2-integration-e2e-benchmark/1422#1:build-log.txt%3A886

Doesn't seem to fix the problem.
/hold

Interesting, now the same failure is coming from a different step. Will take a look. Thanks

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 2, 2020
@amitkrout
Copy link
Contributor Author

/test v4.2-integration-e2e-benchmark

@amitkrout
Copy link
Contributor Author

@mik-dass CI goes green. Can you please review, lift the hold label and ofcourse the lgtm label from your end if changes looks good to you.

@mik-dass
Copy link
Contributor

mik-dass commented Apr 3, 2020

/test v4.3-integration-e2e-benchmark

@mik-dass
Copy link
Contributor

mik-dass commented Apr 3, 2020

/lgtm

@mik-dass mik-dass removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Apr 3, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 3, 2020
@openshift-merge-robot openshift-merge-robot merged commit 918c903 into redhat-developer:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammedzee1000 mohammedzee1000 Awaiting requested review from mohammedzee1000

@prietyc123 prietyc123 Awaiting requested review from prietyc123

Assignees

@mik-dass mik-dass

@prietyc123 prietyc123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prow test are failing due to nodejs-8 image
7 participants
@amitkrout @prietyc123 @girishramnani @openshift-ci-robot @openshift-bot @mik-dass @openshift-merge-robot