Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup Kubernetes cluster on travis CI and handle odo project create on Kubernetes and Openshift cluster #2809

Merged
merged 4 commits into from Apr 16, 2020
Merged

Setup Kubernetes cluster on travis CI and handle odo project create on Kubernetes and Openshift cluster #2809

merged 4 commits into from Apr 16, 2020

Conversation

prietyc123
Copy link
Contributor

@prietyc123 prietyc123 commented Apr 3, 2020 •
edited

What type of PR is this?

/kind test

What does does this PR do / why we need it:

Run integration test for devfiles on kubernetes cluster using travis CI

Which issue(s) this PR fixes:

Fixes - Part of #2752
Fixes #2846

How to test changes / Special notes to the reviewer:

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. kind/test labels Apr 3, 2020
@prietyc123 prietyc123 force-pushed the DevfileIntegratiobTest branch 2 times, most recently from 265b1a3 to ea88f44 Compare April 3, 2020 09:07
@codecov
Copy link

codecov bot commented Apr 3, 2020 •
edited

Codecov Report

Merging #2809 into master will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2809      +/-   ##
==========================================
+ Coverage   43.70%   43.81%   +0.10%     
==========================================
  Files         102      102              
  Lines        9160     9160              
==========================================
+ Hits         4003     4013      +10     
+ Misses       4780     4774       -6     
+ Partials      377      373       -4
Impacted Files Coverage Δ
pkg/watch/watch.go 69.41% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22a6364...0320e97. Read the comment docs.

@prietyc123 prietyc123 force-pushed the DevfileIntegratiobTest branch 11 times, most recently from b3c48d1 to 6312bd0 Compare April 3, 2020 11:29
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Apr 5, 2020
@prietyc123 prietyc123 force-pushed the DevfileIntegratiobTest branch 2 times, most recently from da54349 to 5033663 Compare April 6, 2020 04:45
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Apr 6, 2020
@prietyc123 prietyc123 force-pushed the DevfileIntegratiobTest branch 8 times, most recently from 69ef31d to 1941279 Compare April 6, 2020 06:31
amitkrout
amitkrout reviewed Apr 15, 2020
View reviewed changes
Copy link
Contributor

@amitkrout amitkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 15, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 15, 2020
@amitkrout
Copy link
Contributor

/lgtm

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 15, 2020
@kadel
Copy link
Member

kadel commented Apr 15, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 15, 2020
@prietyc123 prietyc123 mentioned this pull request Apr 15, 2020
Closed
@prietyc123
Copy link
Contributor Author

It seems flake for nodejs has not been resolved : https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/2809/pull-ci-openshift-odo-master-v4.2-integration-e2e-benchmark/1857#1:build-log.txt%3A722
issue : #2641

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@prietyc123
Copy link
Contributor Author

Prow failure : https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/2809/pull-ci-openshift-odo-master-v4.2-integration-e2e-benchmark/1863#1:build-log.txt%3A29

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@prietyc123
Copy link
Contributor Author

Issue on 4.4 cluster : https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/2809/pull-ci-openshift-odo-master-v4.4-integration-e2e-benchmark/10#1:build-log.txt%3A322

tracked in issue : #2887

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 16, 2020
@amitkrout
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 16, 2020
@openshift-merge-robot openshift-merge-robot merged commit 3f49286 into redhat-developer:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitkrout amitkrout amitkrout requested changes

@cdrage cdrage Awaiting requested review from cdrage

@elsony elsony Awaiting requested review from elsony

Assignees

@amitkrout amitkrout

@prietyc123 prietyc123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

odo project create fails for devfile feature on kubernetes cluster
6 participants
@prietyc123 @amitkrout @kadel @openshift-ci-robot @openshift-bot @openshift-merge-robot