Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prow test are failing due to nodejs-8 image #2641

Closed
kadel opened this issue Feb 26, 2020 · 20 comments · Fixed by #2768 or #3414
Closed

Prow test are failing due to nodejs-8 image #2641

kadel opened this issue Feb 26, 2020 · 20 comments · Fixed by #2768 or #3414
Assignees
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering flake Categorizes issue or PR as related to a flaky test. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Projects

Comments

@kadel
Copy link
Member

kadel commented Feb 26, 2020

Prow test are failing due to nodejs-8 image!

ci/prow/v4.2-integration-e2e-benchmark
ci/prow/v4.3-integration-e2e-benchmark

• Failure [397.878 seconds]
odo supported images e2e tests
/go/src/github.com/openshift/odo/tests/e2escenarios/e2e_images_test.go:14
  odo supported images deployment
  /go/src/github.com/openshift/odo/tests/e2escenarios/e2e_images_test.go:137
    Should be able to verify the nodejs-8-centos7 image [It]
    /go/src/github.com/openshift/odo/tests/e2escenarios/e2e_images_test.go:173
    Timeout out after � minutes
    /go/src/github.com/openshift/odo/tests/helper/helper_generic.go:122
------------------------------

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/2637/pull-ci-openshift-odo-master-v4.2-integration-e2e-benchmark/684

/priority critical
/area testing
/kind failing-test

@openshift-ci-robot openshift-ci-robot added priority/Critical We need to stop doing everything and fix this ASAP. It is making the project unusable. area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/failing-test labels Feb 26, 2020
@kadel
Copy link
Member Author

kadel commented Feb 26, 2020

/assign

@kadel
Copy link
Member Author

kadel commented Feb 26, 2020

/unassign

@amitkrout
Copy link
Contributor

amitkrout commented Feb 27, 2020

@prietyc123 @kadel I have tested the same scenario on 4.2 cluster more than 5 times to have atleast one occurrence of failure but none of the the time it hit.

From the logs it is clear that curl command could not hit the route in the specified time limit. Not sure if this is some kind of glitch from network side or from the nodejs application side itself. @kadel Until we are not sure on the issue behaviour till then can we add flake in the title.

@kadel
Copy link
Member Author

kadel commented Feb 27, 2020

Yesterday I saw almost all PRs failing on this.
/kind flake
/priority high
/remove-priority critical
/remove-kind failing-test

@openshift-ci-robot openshift-ci-robot added flake Categorizes issue or PR as related to a flaky test. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). and removed priority/Critical We need to stop doing everything and fix this ASAP. It is making the project unusable. kind/failing-test labels Feb 27, 2020
@kadel
Copy link
Member Author

kadel commented Feb 28, 2020

This is getting really really annoying :-/

Another occurrence in

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/2629/pull-ci-openshift-odo-master-v4.1-integration-e2e-benchmark/754

this time for centos7-s2i-nodejs:10.x image

@kadel kadel added this to For consideration in Sprint 181 via automation Mar 3, 2020
@prietyc123
Copy link
Contributor

prietyc123 commented Mar 6, 2020

@amitkrout I am able to reproduce the error with nodejs-10:latest and centos7-s2i-nodejs:10.x images on 4.2 cluster.

Curl command could not be able to hit for both the images. Need to figure out the reason behind this. May be this is a flake or something because I ran it in verbose mode in a loop and whatever I got in logs for passed scenario is

[odo]  ✓  URL nodejs-app-8080 created for component: nodejs-app
[odo] 
[odo] To create URL on the OpenShift Cluster, please use `odo push`
Running odo with args [odo push --context /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219]
[odo] I0305 18:30:07.846444   60159 preference.go:147] The path for preference file is /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219/config.yaml
[odo] I0305 18:30:07.850779   60159 common_push.go:153] SourceLocation: ./
[odo] I0305 18:30:07.850853   60159 common_push.go:161] Source Path: /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219
[odo] Validation
[odo]  •  Checking component  ...
[odo] I0305 18:30:09.308340   60159 occlient.go:2598] Getting DeploymentConfig: nodejs-app-app
[odo] I0305 18:30:09.908624   60159 component.go:506] Checking source location: ./
[odo]  ✓  Checking component [600ms]
[odo] 
[odo] Configuration changes
[odo]  •  Retrieving component data  ...
[odo] I0305 18:30:10.508910   60159 occlient.go:2598] Getting DeploymentConfig: nodejs-app-app
[odo] I0305 18:30:10.806323   60159 component.go:1023] Source for component nodejs-app is file://./ (local)
[odo] I0305 18:30:10.806348   60159 occlient.go:2598] Getting DeploymentConfig: nodejs-app-app
[odo] I0305 18:30:11.103202   60159 component.go:1149] Updating component nodejs-app, from local to ./ (local).
[odo]  ✓  Retrieving component data [1s]
[odo]  •  Applying configuration  ...
[odo] I0305 18:30:11.396705   60159 occlient.go:748] Found exact image tag match for nodejs:latest
[odo]  ✓  Applying configuration [897ms]
[odo] I0305 18:30:12.001044   60159 url.go:80] Listing routes with label selector: app.kubernetes.io/part-of=app,app.kubernetes.io/instance=nodejs-app
[odo] I0305 18:30:12.001056   60159 occlient.go:2466] Listing routes with label selector: app.kubernetes.io/part-of=app,app.kubernetes.io/instance=nodejs-app
[odo] I0305 18:30:12.290827   60159 url.go:80] Listing routes with label selector: app.kubernetes.io/part-of=app,app.kubernetes.io/instance=nodejs-app
[odo] I0305 18:30:12.290836   60159 occlient.go:2466] Listing routes with label selector: app.kubernetes.io/part-of=app,app.kubernetes.io/instance=nodejs-app
[odo] 
[odo] Applying URL changes
[odo] I0305 18:30:12.576402   60159 occlient.go:2598] Getting DeploymentConfig: nodejs-app-app
[odo]  ✓  URL nodejs-app-8080: http://nodejs-app-8080-app-yvqnyxxpef.apps.ci-ln-t8d0p4b-d5d6b.origin-ci-int-aws.dev.rhcloud.com created
[odo] I0305 18:30:13.263788   60159 url.go:80] Listing routes with label selector: app.kubernetes.io/part-of=app,app.kubernetes.io/instance=nodejs-app
[odo] I0305 18:30:13.263802   60159 occlient.go:2466] Listing routes with label selector: app.kubernetes.io/part-of=app,app.kubernetes.io/instance=nodejs-app
[odo] 
[odo] Pushing to component nodejs-app of type local
[odo]  •  Checking file changes for pushing  ...
[odo] I0305 18:30:13.548300   60159 file_indexer.go:204] .odo or .git directory detected, skipping it
[odo]  ✓  Checking file changes for pushing [2ms]
[odo]  ✓  No file changes detected, skipping build. Use the '-f' flag to force the build.
[odo] I0305 18:30:13.548391   60159 common_push.go:225] List of files to be deleted: +[]
[odo] I0305 18:30:13.548414   60159 odo.go:77] Could not get the latest release information in time. Never mind, exiting gracefully :)
Running odo with args [odo url list --context /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219]
[odo] I0305 18:30:13.642733   60163 preference.go:147] The path for preference file is /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219/config.yaml
[odo] I0305 18:30:14.755128   60163 occlient.go:2466] Listing routes with label selector: app.kubernetes.io/part-of=app,app.kubernetes.io/instance=nodejs-app
[odo] Found the following URLs for component nodejs-app in application app:
[odo] NAME                STATE      URL                                                                                                  PORT
[odo] nodejs-app-8080     Pushed     http://nodejs-app-8080-app-yvqnyxxpef.apps.ci-ln-t8d0p4b-d5d6b.origin-ci-int-aws.dev.rhcloud.com     8080
[odo] I0305 18:30:15.028929   60163 odo.go:77] Could not get the latest release information in time. Never mind, exiting gracefully :)
Checking http://nodejs-app-8080-app-yvqnyxxpef.apps.ci-ln-t8d0p4b-d5d6b.origin-ci-int-aws.dev.rhcloud.com, for Hello
try 0 of 90
Replacing "Hello" with "Hello nodejs UPDATED" in /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219/server.js
Running odo with args [odo push --context /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219]
[odo] I0305 18:30:16.190285   60166 preference.go:147] The path for preference file is /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219/config.yaml
[odo] I0305 18:30:16.190930   60166 common_push.go:153] SourceLocation: ./
[odo] I0305 18:30:16.190944   60166 common_push.go:161] Source Path: /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219
[odo] Validation
[odo]  •  Checking component  ...
[odo] I0305 18:30:17.870460   60166 occlient.go:2598] Getting DeploymentConfig: nodejs-app-app
[odo] I0305 18:30:19.101867   60166 component.go:506] Checking source location: ./
[odo]  ✓  Checking component [1s]
[odo] 
[odo] Configuration changes
[odo]  •  Retrieving component data  ...
[odo] I0305 18:30:19.729839   60166 occlient.go:2598] Getting DeploymentConfig: nodejs-app-app
[odo] I0305 18:30:20.020148   60166 component.go:1023] Source for component nodejs-app is file://./ (local)
[odo] I0305 18:30:20.020190   60166 occlient.go:2598] Getting DeploymentConfig: nodejs-app-app
[odo] I0305 18:30:20.333980   60166 component.go:1149] Updating component nodejs-app, from local to ./ (local).
[odo]  ✓  Retrieving component data [1s]
[odo]  •  Applying configuration  ...
[odo] I0305 18:30:20.943552   60166 occlient.go:748] Found exact image tag match for nodejs:latest
[odo]  ✓  Applying configuration [2s]
[odo] I0305 18:30:22.275890   60166 url.go:80] Listing routes with label selector: app.kubernetes.io/part-of=app,app.kubernetes.io/instance=nodejs-app
[odo] I0305 18:30:22.275903   60166 occlient.go:2466] Listing routes with label selector: app.kubernetes.io/part-of=app,app.kubernetes.io/instance=nodejs-app
[odo] I0305 18:30:22.583165   60166 url.go:80] Listing routes with label selector: app.kubernetes.io/part-of=app,app.kubernetes.io/instance=nodejs-app
[odo] I0305 18:30:22.583176   60166 occlient.go:2466] Listing routes with label selector: app.kubernetes.io/part-of=app,app.kubernetes.io/instance=nodejs-app
[odo] 
[odo] Applying URL changes
[odo] I0305 18:30:23.299023   60166 url.go:80] Listing routes with label selector: app.kubernetes.io/part-of=app,app.kubernetes.io/instance=nodejs-app
[odo] I0305 18:30:23.299036   60166 occlient.go:2466] Listing routes with label selector: app.kubernetes.io/part-of=app,app.kubernetes.io/instance=nodejs-app
[odo]  ✓  URL nodejs-app-8080 already exists
[odo] 
[odo] Pushing to component nodejs-app of type local
[odo]  •  Checking file changes for pushing  ...
[odo] I0305 18:30:23.618219   60166 file_indexer.go:204] .odo or .git directory detected, skipping it
[odo] I0305 18:30:23.618322   60166 file_indexer.go:223] last modified date changed: /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219/server.js
[odo]  ✓  Checking file changes for pushing [2ms]
[odo] I0305 18:30:23.618963   60166 common_push.go:225] List of files to be deleted: +[]
[odo] I0305 18:30:23.618987   60166 common_push.go:248] Copying directory /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219 to pod
[odo] I0305 18:30:23.619012   60166 component.go:635] PushLocal: componentName: nodejs-app, applicationName: app, path: /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219, files: [/var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219/server.js], delFiles: [], isForcePush: false
[odo] I0305 18:30:23.922003   60166 preference.go:147] The path for preference file is /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219/config.yaml
[odo] I0305 18:30:23.922092   60166 occlient.go:1803] Waiting for deploymentconfig=nodejs-app-app pod
[odo]  •  Waiting for component to start  ...
[odo] I0305 18:30:24.451222   60166 occlient.go:1827] Status of nodejs-app-app-1-5p7zg pod is Running
[odo] I0305 18:30:24.451253   60166 occlient.go:1831] Pod nodejs-app-app-1-5p7zg is Running
[odo]  ✓  Waiting for component to start [529ms]
[odo]  •  Syncing files to the component  ...
[odo] I0305 18:30:24.451351   60166 component.go:701] Copying files /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219/server.js to pod
[odo] I0305 18:30:24.451366   60166 occlient.go:2689] CopyFile arguments: localPath /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219, dest /tmp/src/135032219, copyFiles [/var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219/server.js], globalExps [/var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219/.git /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219/.odo/odo-file-index.json]
[odo] I0305 18:30:24.451447   60166 occlient.go:2737] makeTar arguments: srcPath: /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219, destPath: /tmp/src/135032219, files: [/var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219/server.js]
[odo] I0305 18:30:24.451548   60166 occlient.go:2751] Got abs path: /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219/server.js
[odo] I0305 18:30:24.451559   60166 occlient.go:2752] Making /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219 relative to /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219/server.js
[odo] I0305 18:30:24.451591   60166 occlient.go:2780] recursiveTar arguments: srcBase: /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T, srcFile: 135032219/server.js, destBase: /tmp/src, destFile: 135032219/server.js
[odo] I0305 18:30:24.451601   60166 occlient.go:2786] Corrected destinations: base: /tmp/src file: 135032219/server.js
[odo]  ✓  Syncing files to the component [3s]
[odo]  •  Building component  ...
[odo] + set -eo pipefail
[odo] + export ODO_UTILS_DIR=/opt/odo
[odo] + ODO_UTILS_DIR=/opt/odo
[odo] + export ODO_IMAGE_MAPPINGS_FILE=/opt/odo/language-scripts/image-mappings.json
[odo] + ODO_IMAGE_MAPPINGS_FILE=/opt/odo/language-scripts/image-mappings.json
[odo] ++ /opt/odo/bin/getlanguage
[odo] + IMAGE_LANG=nodejs
[odo] + '[' '!' -z /opt/app-root/src ']'
[odo] + '[' /tmp '!=' /opt/app-root/src ']'
[odo] + '[' -n /opt/app-root/src-backup ']'
[odo] + '[' '!' -d /opt/app-root/src-backup ']'
[odo] + rsync -rlO /tmp/src/. /opt/app-root/src-backup/src/
[odo] + b_IFS=' 	
[odo] '
[odo] + b_OFS=
[odo] + OIFS=' 	
[odo] '
[odo] + IFS='
[odo] '
[odo] ++ ls -A /tmp/src/
[odo] + for file in '`ls -A ${ODO_S2I_SRC_BIN_PATH}/src/`'
[odo] + rm -fr /opt/app-root/src/.dummy
[odo] + for file in '`ls -A ${ODO_S2I_SRC_BIN_PATH}/src/`'
[odo] + rm -fr /opt/app-root/src/.gitignore
[odo] + for file in '`ls -A ${ODO_S2I_SRC_BIN_PATH}/src/`'
[odo] + rm -fr /opt/app-root/src/.odo
[odo] + for file in '`ls -A ${ODO_S2I_SRC_BIN_PATH}/src/`'
[odo] + rm -fr /opt/app-root/src/package.json
[odo] + for file in '`ls -A ${ODO_S2I_SRC_BIN_PATH}/src/`'
[odo] + rm -fr /opt/app-root/src/server.js
[odo] + OIFS=
[odo] + IFS=' 	
[odo] '
[odo] + '[' -n rhscl/nodejs-8-rhel7 ']'
[odo] + '[' rhscl/nodejs-8-rhel7 == redhat-openjdk-18/openjdk18-openshift ']'
[odo] + '[' -f /tmp/src/.s2i/bin/assemble ']'
[odo] + '[' -n nodejs ']'
[odo] + /opt/odo/language-scripts/nodejs/dev-assemble
[odo] + DEV_MODE=true
[odo] + REFRESH_WORKING_DIR=/tmp/refresh/
[odo] + PACKAGE_SHA_FILE=/tmp/refresh//package.json.sha1
[odo] + mkdir -p /tmp/refresh/
[odo] + '[' -z '' ']'
[odo] + '[' true == true ']'
[odo] + export NODE_ENV=development
[odo] + NODE_ENV=development
[odo] + '[' development == production ']'
[odo] + export DEV_MODE=true
[odo] + DEV_MODE=true
[odo] + '[' true == true ']'
[odo] + set -x
[odo] + echo '---> Installing application source'
[odo] + cp -Rf /tmp/src/. ./
[odo] + '[' true == true ']'
[odo] + '[' -f /tmp/refresh//package.json.sha1 ']'
[odo] ++ sha1sum -c /tmp/refresh//package.json.sha1
[odo] + out='package.json: OK'
[odo] + '[' 'package.json: OK' == 'package.json: OK' ']'
[odo] + echo '---> package.json is the same as last time, no changes needed.'
[odo] + echo '---> Fix permissions on app-root'
[odo] + fix-permissions /opt/app-root
[odo] + exit 0
[odo] + '[' '!' -z /opt/app-root/src ']'
[odo] + '[' -n /opt/app-root/src-backup ']'
[odo] + '[' /tmp '!=' /opt/app-root/src ']'
[odo] + '[' /opt/app-root/src '!=' /opt/app-root/src ']'
[odo] ---> Installing application source
[odo] ---> package.json is the same as last time, no changes needed.
[odo] ---> Fix permissions on app-root
[odo] + PV_MNT_PT=/opt/app-root
[odo] + sed -i s/autostart=false/autostart=true/g /opt/app-root/conf/supervisor.conf
[odo] + /opt/odo/bin/supervisord ctl stop run
[odo] + /opt/odo/bin/supervisord ctl start run
[odo] run: stopped
[odo] run: started
[odo] I0305 18:30:31.924549   60166 odo.go:77] Could not get the latest release information in time. Never mind, exiting gracefully :)
[odo]  ✓  Building component [5s]
[odo]  ✓  Changes successfully pushed to component
Checking http://nodejs-app-8080-app-yvqnyxxpef.apps.ci-ln-t8d0p4b-d5d6b.origin-ci-int-aws.dev.rhcloud.com, for Hello nodejs UPDATED
try 0 of 90
Running command:  [odo watch nodejs-app -v 4 --context /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219]
Running curl with args [curl http://nodejs-app-8080-app-yvqnyxxpef.apps.ci-ln-t8d0p4b-d5d6b.origin-ci-int-aws.dev.rhcloud.com]
Deleting dir: /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219/abcd
Replacing "Hello" with "Hello odo" in /var/folders/g8/f12mz2jj1ygbsq8v51fz7dvr0000gn/T/135032219/server.js
[curl]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[curl]                                  Dload  Upload   Total   Spent    Left  Speed
[curl] 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    42    0    42    0     0     78      0 --:--:-- --:--:-- --:--:--    78
[curl] Hello nodejs UPDATED world from node.js!
[curl] 
Running curl with args [curl http://nodejs-app-8080-app-yvqnyxxpef.apps.ci-ln-t8d0p4b-d5d6b.origin-ci-int-aws.dev.rhcloud.com]
[curl]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[curl]                                  Dload  Upload   Total   Spent    Left  Speed
[curl] 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0Hello odo nodejs UPDATED world from node.js!
[curl] 
[curl] 
100    46    0    46    0     0     84      0 --:--:-- --:--:-- --:--:--    84
Running oc with args [oc get pods --namespace yvqnyxxpef --show-labels]
[oc] NAME                      READY   STATUS      RESTARTS   AGE     LABELS
[oc] nodejs-app-app-1-5p7zg    1/1     Running     0          2m5s    deployment=nodejs-app-app-1,deploymentconfig=nodejs-app-app
[oc] nodejs-app-app-1-deploy   0/1     Completed   0          2m13s   openshift.io/deployer-pod-for.name=nodejs-app-app-1
Running oc with args [oc get dc nodejs-app-app --namespace yvqnyxxpef -o jsonpath='{range .spec.template.spec.containers[0].env[*]}{.name}:{.value}{"\n"}{end}']
[oc] 'DEBUG_PORT:5858
[oc] ODO_S2I_SCRIPTS_URL:/usr/libexec/s2i

and with this log I am thinking that it could be a flake. In verbose mode also the failure logs are same as stated https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/2629/pull-ci-openshift-odo-master-v4.1-integration-e2e-benchmark/754

@girishramnani girishramnani moved this from For consideration to To do in Sprint 181 Mar 11, 2020
@prietyc123
Copy link
Contributor

@kadel I ran the test yesterday and today also in a loops but now I am not getting this error. Although I will be running it again and will update further.

@amitkrout
Copy link
Contributor

The same failure first time hit in java:8 component too against 4.1 cluster - https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/2755/pull-ci-openshift-odo-master-v4.1-integration-e2e-benchmark/1301#1:build-log.txt%3A885

Tried locally twice and none of the time i hit the issue. Now i am going to send a pr to get atleast few info like oc get pod, oc get dc, oc get dc -o yaml just after the component push may be helpful to debug the issue.

@amitkrout
Copy link
Contributor

Ahh...
Finally got the problem. I think the issue is with watch function pointing to another context dir (Due to the race condition in parallel run).

Will send the PR today itself

@girishramnani girishramnani added this to For consideration in Sprint 182 via automation Mar 30, 2020
@girishramnani girishramnani removed this from To do in Sprint 181 Mar 30, 2020
@girishramnani girishramnani moved this from For consideration to To do in Sprint 182 Mar 30, 2020
@amitkrout amitkrout moved this from To do to In progress in Sprint 182 Mar 30, 2020
@amitkrout
Copy link
Contributor

@dharmit
Copy link
Member

dharmit commented May 27, 2020

Seeing a failure for this on PR #3239:

  • 4.2 integration tests failure for centos7-s2i-nodejs image - link to logs
  • 4.5 integration tests failure for nodejs-8-rhel7 image - link to logs.

@amitkrout amitkrout added this to For consideration in Sprint 185 via automation Jun 4, 2020
@amitkrout amitkrout moved this from For consideration to To do in Sprint 185 Jun 4, 2020
@amitkrout amitkrout removed this from Done in Sprint 182 Jun 4, 2020
@girishramnani
Copy link
Contributor

we would remove the nodejs 8 image related tests

@girishramnani
Copy link
Contributor

@amitkrout please open a separate issue for more of the scope discussed

@amitkrout
Copy link
Contributor

amitkrout commented Jun 5, 2020

@amitkrout please open a separate issue for more of the scope discussed

@girishramnani As discussed i have created separate issue #3307.

Also we had a discussion on the supported images that nodejs8 has been deprecated, @girishramnani however i can still see these container images in the supported list https://github.com/openshift/odo-init-image/blob/master/language-scripts/image-mappings.json#L5-L15 and in the odo README too - https://github.com/openshift/odo#officially-supported-languages-and-corresponding-container-images. We should remove those reference aswell, right ? I will create a separate issue or will directly send a pr to update these reference.

@dharmit
Copy link
Member

dharmit commented Jun 22, 2020

@amitkrout to do write-up explaining the problem and how to fix it.

@amitkrout
Copy link
Contributor

@amitkrout to do write-up explaining the problem and how to fix it.

I have created a separate issue #3307 as per the comment #2641 (comment). The cause of failure and fix will be discussed in #3307.

Actually i am waiting for @girishramnani comment on my last comment. Then only i can decide the next task, otherwise i will close the issue.

@amitkrout amitkrout assigned girishramnani and unassigned amitkrout Jun 24, 2020
@girishramnani
Copy link
Contributor

why do we still have nodejs-8 images?

@girishramnani girishramnani moved this from To do to For review in Sprint 186 Jun 24, 2020
Sprint 186 automation moved this from For review to Done Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering flake Categorizes issue or PR as related to a flaky test. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Projects
No open projects
Sprint 186
  
Done
6 participants