-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prow test are failing due to nodejs-8 image #2641
Comments
/assign |
/unassign |
@prietyc123 @kadel I have tested the same scenario on 4.2 cluster more than 5 times to have atleast one occurrence of failure but none of the the time it hit. From the logs it is clear that curl command could not hit the route in the specified time limit. Not sure if this is some kind of glitch from network side or from the nodejs application side itself. @kadel Until we are not sure on the issue behaviour till then can we add flake in the title. |
Yesterday I saw almost all PRs failing on this. |
This is getting really really annoying :-/ Another occurrence in this time for centos7-s2i-nodejs:10.x image |
@amitkrout I am able to reproduce the error with Curl command could not be able to hit for both the images. Need to figure out the reason behind this. May be this is a flake or something because I ran it in verbose mode in a loop and whatever I got in logs for passed scenario is
and with this log I am thinking that it could be a flake. In verbose mode also the failure logs are same as stated https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/2629/pull-ci-openshift-odo-master-v4.1-integration-e2e-benchmark/754 |
@kadel I ran the test yesterday and today also in a loops but now I am not getting this error. Although I will be running it again and will update further. |
The same failure first time hit in java:8 component too against 4.1 cluster - https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/2755/pull-ci-openshift-odo-master-v4.1-integration-e2e-benchmark/1301#1:build-log.txt%3A885 Tried locally twice and none of the time i hit the issue. Now i am going to send a pr to get atleast few info like |
Ahh... Will send the PR today itself |
@prietyc123 Thanks for reporting it. Will take a look. |
Seeing a failure for this on PR #3239:
|
we would remove the nodejs 8 image related tests |
@amitkrout please open a separate issue for more of the scope discussed |
@girishramnani As discussed i have created separate issue #3307. Also we had a discussion on the supported images that nodejs8 has been deprecated, @girishramnani however i can still see these container images in the supported list https://github.com/openshift/odo-init-image/blob/master/language-scripts/image-mappings.json#L5-L15 and in the odo README too - https://github.com/openshift/odo#officially-supported-languages-and-corresponding-container-images. We should remove those reference aswell, right ? I will create a separate issue or will directly send a pr to update these reference. |
@amitkrout to do write-up explaining the problem and how to fix it. |
I have created a separate issue #3307 as per the comment #2641 (comment). The cause of failure and fix will be discussed in #3307. Actually i am waiting for @girishramnani comment on my last comment. Then only i can decide the next task, otherwise i will close the issue. |
why do we still have nodejs-8 images? |
Prow test are failing due to nodejs-8 image!
ci/prow/v4.2-integration-e2e-benchmark
ci/prow/v4.3-integration-e2e-benchmark
https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/2637/pull-ci-openshift-odo-master-v4.2-integration-e2e-benchmark/684
/priority critical
/area testing
/kind failing-test
The text was updated successfully, but these errors were encountered: