Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes now flag push. #2870

Merged
merged 1 commit into from Apr 13, 2020
Merged

Conversation

mik-dass
Copy link
Contributor

@mik-dass mik-dass commented Apr 13, 2020

Signed-off-by: mik-dass mrinald7@gmail.com

What type of PR is this?

/kind flake

What does does this PR do / why we need it:

It also fixes the integration test of now flag for config.

Which issue(s) this PR fixes:

Fixes #2642

How to test changes / Special notes to the reviewer:

  • make test-cmd-pref-config should pass locally and on the CI
  • any -now operation should build and push the component e.g

Current behaviour

[mrinaldas@localhost nodejs-ex]$ odo url create example --now
 ✓  Checking component [2s]
 ✓  URL example created for component: nodejs-nodejs-ex-alyi

Configuration changes
 ✓  Initializing component
 ✓  Creating component [4s]

Applying URL changes
 ✓  URL example: http://example-app-nwfjoupivp.b6ff.rh-idev.openshiftapps.com created

Pushing to component nodejs-nodejs-ex-alyi of type 
 ✓  Checking files for pushing [55ms]
 ✓  Changes successfully pushed to component

Expected

[mrinaldas@localhost nodejs-ex]$ odo url create example --now
 ✓  Checking component [12s]
 ✓  URL example created for component: nodejs-nodejs-ex-dsbe

Configuration changes
 ✓  Initializing component
 ✓  Creating component [11s]

Applying URL changes
 ✓  URL example: http://example-app-nwfjoupivp.b6ff.rh-idev.openshiftapps.com created

Pushing to component nodejs-nodejs-ex-dsbe of type local
 ✓  Checking files for pushing [17ms]
 ✓  Waiting for component to start [16s]
 ✓  Syncing files to the component [27s]
 ✓  Building component [9s]
 ✓  Changes successfully pushed to component

It also fixes the integration test of now flag for config.

Signed-off-by: mik-dass <mrinald7@gmail.com>
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. flake Categorizes issue or PR as related to a flaky test. labels Apr 13, 2020
@mik-dass mik-dass changed the title [WIP] Fixes now flag push. Fixes now flag push. Apr 13, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Apr 13, 2020
@girishramnani
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 13, 2020
@prietyc123
Copy link
Contributor

looks good to me
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 13, 2020
@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #2870 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2870   +/-   ##
=======================================
  Coverage   43.30%   43.30%           
=======================================
  Files          97       97           
  Lines        8878     8878           
=======================================
  Hits         3845     3845           
  Misses       4669     4669           
  Partials      364      364           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f25c90...bd1ef62. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit 749739a into redhat-developer:master Apr 13, 2020
@mik-dass mik-dass deleted the now_fix branch April 13, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky tests for --now flag
5 participants