Skip to content

Commit

Permalink
Fixes now flag push. (#2870)
Browse files Browse the repository at this point in the history
It also fixes the integration test of now flag for config.

Signed-off-by: mik-dass <mrinald7@gmail.com>
  • Loading branch information
mik-dass authored Apr 13, 2020
1 parent 5f25c90 commit 749739a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions pkg/odo/cli/component/common_push.go
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ func (cpo *CommonPushOptions) Push() (err error) {

cmpName := cpo.LocalConfigInfo.GetName()
appName := cpo.LocalConfigInfo.GetApplication()
cpo.sourceType = cpo.LocalConfigInfo.GetSourceType()

if cpo.componentContext == "" {
cpo.componentContext = strings.TrimSuffix(filepath.Dir(cpo.LocalConfigInfo.Filename), ".odo")
Expand Down
1 change: 1 addition & 0 deletions tests/integration/cmd_pref_config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,7 @@ var _ = Describe("odo preference and config command tests", func() {

It("should successfully set and unset variables", func() {
//set env var
helper.CopyExample(filepath.Join("source", "nodejs"), context)
helper.CmdShouldPass("odo", "create", "nodejs", "nodejs", "--project", project, "--context", context)
helper.CmdShouldPass("odo", "config", "set", "--now", "--env", "hello=world", "--context", context)
//*Check config
Expand Down

0 comments on commit 749739a

Please sign in to comment.