add source type field in all odo list variants ( json and standard ) #2880
Conversation
openshift-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold the poor bot is trying to restart the tests that are clearly broken :-/ unhold when fixed |
openshift-ci-robot
added
do-not-merge/hold
girishramnani
force-pushed
the
source_type_odo_list
branch
from
e51c6fd
to
7712ee4
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
openshift-ci-robot
added
the
lgtm
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Codecov Report
@@ Coverage Diff @@
## master #2880 +/- ##
=======================================
Coverage 43.70% 43.70%
=======================================
Files 102 102
Lines 9160 9163 +3
=======================================
+ Hits 4003 4005 +2
- Misses 4780 4781 +1
Partials 377 377
Continue to review full report at Codecov.
|
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
@girishramnani: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
cdrage
added
the
kind/feature
What type of PR is this?
/kind feature
What does does this PR do / why we need it:
adds
sourceTypein json output and standard output forodo list.Which issue(s) this PR fixes:
Fixes #2730
How to test changes / Special notes to the reviewer:
Create a component and before pushing
odo listodo list --all-appsodo list --path .should give
SOURCETYPEcolumn and similarly-o jsonvariants should give json output.Now push the component and try the same.
when a component is not pushed the code path is different as the component is not present on the cluster and hence the reviewer should check if
sourceTypeshows in that case as well or not.