-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add source type field in all odo list variants ( json and standard ) #2880
add source type field in all odo list variants ( json and standard ) #2880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/hold the poor bot is trying to restart the tests that are clearly broken :-/ unhold when fixed |
e51c6fd
to
7712ee4
Compare
/hold cancel |
/lgtm |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
Codecov Report
@@ Coverage Diff @@
## master #2880 +/- ##
=======================================
Coverage 43.70% 43.70%
=======================================
Files 102 102
Lines 9160 9163 +3
=======================================
+ Hits 4003 4005 +2
- Misses 4780 4781 +1
Partials 377 377
Continue to review full report at Codecov.
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
@girishramnani: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
What type of PR is this?
/kind feature
What does does this PR do / why we need it:
adds
sourceType
in json output and standard output forodo list
.Which issue(s) this PR fixes:
Fixes #2730
How to test changes / Special notes to the reviewer:
Create a component and before pushing
odo list
odo list --all-apps
odo list --path .
should give
SOURCETYPE
column and similarly-o json
variants should give json output.Now push the component and try the same.
when a component is not pushed the code path is different as the component is not present on the cluster and hence the reviewer should check if
sourceType
shows in that case as well or not.