Adding oc from build to container image in multistage

[prietyc123]

What type of PR is this?

/kind feature

What does does this PR do / why we need it:

Adds oc binary to the container image as mentioned in comment

Which issue(s) this PR fixes:

Fixes NA

How to test changes / Special notes to the reviewer:

This is just a pre-requisite for pr openshift/release#9431

[prietyc123]

/test unit

[codecov]

Codecov Report

Merging #3418 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3418      +/-   ##
==========================================
- Coverage   46.27%   46.25%   -0.02%     
==========================================
  Files         112      112              
  Lines       11214    11214              
==========================================
- Hits         5189     5187       -2     
- Misses       5523     5525       +2     
  Partials      502      502              

Impacted Files	Coverage Δ
pkg/sync/sync.go	45.54% <0.00%> (-1.99%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d9a030...c09eb5c. Read the comment docs.

[amitkrout]

/lgtm

[prietyc123]

I am adding a new dockerfile to inject oc into the container and this change is not going to break our master. I will consume this dockerfile into multistage migration in pr openshift/release#9431

[amitkrout]

Copy paste from #3270 (comment)

Unlike other project we tried a nice and simple shell script workaround to inject oc binary to the test container path but unfortunately it did not work for a reason which even surprises @petr-muller from platform team. We should not spend more time on it to debug as this is a workaround ,so we can follow the same way like other project has been done it through another Dockerfile instead. For example - https://github.com/openshift-knative/serverless-operator/tree/6805a2d1b560dbc6955ad1d4aa9686f5d8f8a9c8/openshift/ci-operator.

Shell script workaround we tried - https://github.com/openshift/odo/blob/master/openshift-ci/build-root/multistage/check-oc.sh
Build log - https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_release/9431/rehearse-9431-pull-ci-openshift-odo-master-v4.2-images/1276035075401584640/artifacts/build-logs/oc-bin-image.log

NOTE: oc binary auto injection feature is not delivered yet - https://issues.redhat.com/browse/DPTP-1242

EDIT: #3270 (comment)

Ping @dharmit @kadel @girishramnani

[amitkrout]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitkrout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• openshift-ci/build-root/OWNERS [amitkrout]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@prietyc123: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/v4.2-integration-e2e	c09eb5c	link	/test v4.2-integration-e2e
ci/prow/v4.5-integration-e2e	c09eb5c	link	/test v4.5-integration-e2e
ci/prow/v4.4-integration-e2e	c09eb5c	link	/test v4.4-integration-e2e
ci/prow/v4.3-integration-e2e	c09eb5c	link	/test v4.3-integration-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[amitkrout]

It's new docker file change which even does affect the master. More importantly we can unblock the pr openshift/release#9431. So I am merging it forcefully to avoid unnecessary time waste.