Porting template based test to multi-stage testing #9431

prietyc123 · 2020-06-02T09:55:51Z

Followed multistage documentation https://ci-operator-configresolver-ui-ci.apps.ci.l2s4.p1.openshiftapps.com/help and used the ipi-aws workflow

prietyc123 · 2020-06-02T09:56:25Z

ping @amitkrout @mohammedzee1000

prietyc123 · 2020-06-02T10:15:22Z

/retest

amitkrout · 2020-06-02T10:31:42Z

/refresh

amitkrout · 2020-06-02T10:31:57Z

/test pj-rehearse

amitkrout · 2020-06-02T10:32:27Z

/retest

droslean · 2020-06-03T10:12:49Z

/test pj-rehearse

mohammedzee1000 · 2020-06-03T13:45:26Z

/test pj-rehearse

prietyc123 · 2020-06-09T05:01:59Z

/test pj-rehearse

prietyc123 · 2020-06-09T07:21:58Z

/test pj-rehearse

amitkrout · 2020-06-09T11:08:57Z

@prietyc123 similar failure i can observe in template based test aswell - https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/pr-logs/pull/openshift_release/9427/rehearse-9427-periodic-ci-openshift-odo-master-v4.2-integration-e2e-periodic/6

I don't think your failure is specific to the multi-stage migration.

Considering this is a temporary glitch, i am re running the test. Otherwise it better to involve platform team

/retest

prietyc123 · 2020-06-10T09:44:21Z

/retest

prietyc123 · 2020-06-10T09:50:57Z

/refresh

prietyc123 · 2020-06-10T09:51:09Z

/test pj-rehearse

prietyc123 · 2020-06-10T14:48:57Z

/retest

prietyc123 · 2020-07-22T09:29:00Z

/retest

prietyc123 · 2020-07-23T04:40:29Z

[odo]  ⚠  Warning! Projects are deleted from the cluster asynchronously. Odo does its best to delete the project. Due to multi-tenant clusters, the project may still exist on a different node.
[odo] I0722 12:58:46.355542   22106 odo.go:72] Could not get the latest release information in time. Never mind, exiting gracefully :)
Deleting dir: /tmp/933989126
------------------------------
• Failure [1.328 seconds]
odo project command tests
/go/src/github.com/openshift/odo/tests/integration/project/cmd_project_test.go:15
  odo machine readable output on empty project
  /go/src/github.com/openshift/odo/tests/integration/project/cmd_project_test.go:52
    should be able to list current project [It]
    /go/src/github.com/openshift/odo/tests/integration/project/cmd_project_test.go:53
    Expected
      
        <string>: {"apiVersion":"odo.dev/v1alpha1","items":[{"apiVersion":"odo.dev/v1alpha1","kind":"Project","metadata":{"creationTimestamp":null,"name":"bxcnmtlnql","namespace":"bxcnmtlnql"},"spec":{},"status":{"active":false}},{"apiVersion":"odo.dev/v1alpha1","kind":"Project","metadata":{"creationTimestamp":null,"name":"ci-operator-hub-project","namespace":"ci-operator-hub-project"},"spec":{},"status":{"active":false}},{"apiVersion":"odo.dev/v1alpha1","kind":"Project","metadata":{"creationTimestamp":null,"name":"jbfjcfttsl","namespace":"jbfjcfttsl"},"spec":{},"status":{"active":false}},{"apiVersion":"odo.dev/v1alpha1","kind":"Project","metadata":{"creationTimestamp":null,"name":"myproject","namespace":"myproject"},"spec":{},"status":{"active":false}},{"apiVersion":"odo.dev/v1alpha1","kind":"Project","metadata":{"creationTimestamp":null,"name":"usidsppjct","namespace":"usidsppjct"},"spec":{},"status":{"active":false}},{"apiVersion":"odo.dev/v1alpha1","kind":"Project","metadata":{"creationTimestamp":null,"name":"xpjoeyayjk","namespace":"xpjoeyayjk"},"spec":{},"status":{"active":false}}],"kind":"List","metadata":{}}
    to contain substring
        <string>: {"apiVersion":"odo.dev/v1alpha1","kind":"Project","metadata":{"creationTimestamp":null,"name":"segqikjqrv","namespace":"segqikjqrv"},"spec":{},"status":{"active":true}}
    /go/src/github.com/openshift/odo/tests/integration/project/cmd_project_test.go:59
------------------------------
•••
Summarizing 1 Failure:
[Fail] odo project command tests odo machine readable output on empty project [It] should be able to list current project 
/go/src/github.com/openshift/odo/tests/integration/project/cmd_project_test.go:59
Ran 6 of 6 Specs in 21.181 seconds
FAIL! -- 5 Passed | 1 Failed | 0 Pending | 0 Skipped

Its a flake resolved through pr redhat-developer/odo#3620

/retest

amitkrout · 2020-07-23T05:59:42Z

ci-operator/config/openshift/odo/openshift-odo-master__v4.5.yaml

- as: integration-e2e
-  commands: scripts/openshiftci-presubmit-all-tests.sh
-  openshift_installer_src:
+- as: integration-e2e-steps


Can we remove steps from the test name ?

As we have nested steps and we can not use same name for both the steps in line 28 and 32 https://github.com/openshift/release/pull/9431/files#diff-cf06122cc7ac596bba3930b965d2e59bR28-R32 . I have already checked that it won't work in that way. So IMO integration-e2e-steps best suit for this. Anyway I am open to any test name.

The same name is being reflected in job name.

The job name we have been using since long time should not be change for no cause. So you can rename this as - as: integration-e2e and update the name https://github.com/openshift/release/pull/9431/files#diff-cf06122cc7ac596bba3930b965d2e59bR32 to - as: integration-e2e-steps to avoid any conflict.

The same name is being reflected in job name.

The job name we have been using since long time should not be change for no cause. So you can rename this as - as: integration-e2e and update the name https://github.com/openshift/release/pull/9431/files#diff-cf06122cc7ac596bba3930b965d2e59bR32 to - as: integration-e2e-steps to avoid any conflict.

This makes sense to me as well 👍

prietyc123 · 2020-07-23T07:45:14Z

@petr-muller Thanks for all your valuable inputs through out the multistage migration for odo test.
I have done with the changes having a basic configuration of multistage test infra . Can you please take a look.

petr-muller · 2020-07-23T08:59:47Z

LGTM

openshift-ci-robot · 2020-07-23T11:19:45Z

@prietyc123: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/rehearse/openshift/odo/master/v4.2-integration-e2e-steps	803c130f7ceed3fc9ee74a4e5d6b16cf0b46bca7	link	`/test pj-rehearse`
ci/rehearse/periodic-ci-openshift-odo-master-v4.5-integration-e2e-periodic	`11c29e7`	link	`/test pj-rehearse`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

prietyc123 · 2020-07-23T11:39:33Z

/retest

amitkrout

/lgtm

mohammedzee1000

Looking good

girishramnani · 2020-07-23T14:13:32Z

Trusting ur judgment on this @amitkrout
/approve

mik-dass · 2020-07-23T14:18:56Z

/approve

openshift-ci-robot · 2020-07-23T14:19:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitkrout, girishramnani, mik-dass, mohammedzee1000, prietyc123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/odo/OWNERS~~ [mik-dass]
~~ci-operator/jobs/openshift/odo/OWNERS~~ [mik-dass]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-07-23T14:33:14Z

@prietyc123: Updated the following 3 configmaps:

ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
- key openshift-odo-master__v4.2.yaml using file ci-operator/config/openshift/odo/openshift-odo-master__v4.2.yaml
- key openshift-odo-master__v4.3.yaml using file ci-operator/config/openshift/odo/openshift-odo-master__v4.3.yaml
- key openshift-odo-master__v4.4.yaml using file ci-operator/config/openshift/odo/openshift-odo-master__v4.4.yaml
- key openshift-odo-master__v4.5.yaml using file ci-operator/config/openshift/odo/openshift-odo-master__v4.5.yaml
job-config-master configmap in namespace ci at cluster api.ci using the following files:
- key openshift-odo-master-periodics.yaml using file ci-operator/jobs/openshift/odo/openshift-odo-master-periodics.yaml
- key openshift-odo-master-presubmits.yaml using file ci-operator/jobs/openshift/odo/openshift-odo-master-presubmits.yaml
job-config-master configmap in namespace ci at cluster app.ci using the following files:
- key openshift-odo-master-periodics.yaml using file ci-operator/jobs/openshift/odo/openshift-odo-master-periodics.yaml
- key openshift-odo-master-presubmits.yaml using file ci-operator/jobs/openshift/odo/openshift-odo-master-presubmits.yaml

In response to this:

Issue Ref : redhat-developer/odo#3270

Followed multistage documentation https://ci-operator-configresolver-ui-ci.apps.ci.l2s4.p1.openshiftapps.com/help and used the ipi-aws workflow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from adisky and mik-dass June 2, 2020 09:56

prietyc123 force-pushed the MigrateTemplateBasedToMultiStageTest branch from b1ab4a8 to c00f990 Compare June 2, 2020 10:11

prietyc123 mentioned this pull request Jun 3, 2020

Removing unused secret directory redhat-developer/odo#3290

Merged

prietyc123 force-pushed the MigrateTemplateBasedToMultiStageTest branch from c00f990 to 1d002a7 Compare June 10, 2020 08:46

prietyc123 force-pushed the MigrateTemplateBasedToMultiStageTest branch 2 times, most recently from 76fe05b to f559654 Compare June 10, 2020 14:41

prietyc123 force-pushed the MigrateTemplateBasedToMultiStageTest branch 9 times, most recently from 654a233 to 6b3a624 Compare June 12, 2020 05:18

prietyc123 force-pushed the MigrateTemplateBasedToMultiStageTest branch from 2de0767 to 25c4e0c Compare July 22, 2020 08:24

prietyc123 force-pushed the MigrateTemplateBasedToMultiStageTest branch from 25c4e0c to 1e4bd9a Compare July 22, 2020 10:32

amitkrout reviewed Jul 23, 2020

View reviewed changes

prietyc123 added 7 commits July 23, 2020 12:33

Porting template based test to multi-stage testing

d53c147

Applying oc bin image

d3fdfa3

Added change to the periodic jobs according to multistage

7c72e6e

Changing source image path

2bb4b6a

Increased the limit and requested resource on 4.5 cluster

5c33e34

reverting the limit and requested resource

54e1efe

Addressed review comment for test name change

11c29e7

prietyc123 force-pushed the MigrateTemplateBasedToMultiStageTest branch from 1e4bd9a to 11c29e7 Compare July 23, 2020 07:18

prietyc123 requested a review from amitkrout July 23, 2020 07:19

amitkrout reviewed Jul 23, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2020

mohammedzee1000 approved these changes Jul 23, 2020

View reviewed changes

openshift-ci-robot assigned mohammedzee1000 Jul 23, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2020

openshift-merge-robot merged commit 8860050 into openshift:master Jul 23, 2020

prietyc123 mentioned this pull request Jul 23, 2020

Porting template based test to Multi Stage testing redhat-developer/odo#3270

Closed

2 tasks

amitkrout mentioned this pull request Jul 24, 2020

Run integration e2e test on mac and windows redhat-developer/odo#3143

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Porting template based test to multi-stage testing #9431

Porting template based test to multi-stage testing #9431

prietyc123 commented Jun 2, 2020 •

edited

Loading

prietyc123 commented Jun 2, 2020

prietyc123 commented Jun 2, 2020

amitkrout commented Jun 2, 2020

amitkrout commented Jun 2, 2020

amitkrout commented Jun 2, 2020

droslean commented Jun 3, 2020

mohammedzee1000 commented Jun 3, 2020

prietyc123 commented Jun 9, 2020

prietyc123 commented Jun 9, 2020

amitkrout commented Jun 9, 2020

prietyc123 commented Jun 10, 2020

prietyc123 commented Jun 10, 2020

prietyc123 commented Jun 10, 2020

prietyc123 commented Jun 10, 2020

prietyc123 commented Jul 22, 2020

prietyc123 commented Jul 23, 2020 •

edited

Loading

amitkrout Jul 23, 2020 •

edited

Loading

prietyc123 Jul 23, 2020

amitkrout Jul 23, 2020 •

edited

Loading

prietyc123 Jul 23, 2020

prietyc123 commented Jul 23, 2020

petr-muller commented Jul 23, 2020

openshift-ci-robot commented Jul 23, 2020 •

edited

Loading

prietyc123 commented Jul 23, 2020

amitkrout left a comment

mohammedzee1000 left a comment

girishramnani commented Jul 23, 2020

mik-dass commented Jul 23, 2020

openshift-ci-robot commented Jul 23, 2020

openshift-ci-robot commented Jul 23, 2020

Porting template based test to multi-stage testing #9431

Porting template based test to multi-stage testing #9431

Conversation

prietyc123 commented Jun 2, 2020 • edited Loading

prietyc123 commented Jun 2, 2020

prietyc123 commented Jun 2, 2020

amitkrout commented Jun 2, 2020

amitkrout commented Jun 2, 2020

amitkrout commented Jun 2, 2020

droslean commented Jun 3, 2020

mohammedzee1000 commented Jun 3, 2020

prietyc123 commented Jun 9, 2020

prietyc123 commented Jun 9, 2020

amitkrout commented Jun 9, 2020

prietyc123 commented Jun 10, 2020

prietyc123 commented Jun 10, 2020

prietyc123 commented Jun 10, 2020

prietyc123 commented Jun 10, 2020

prietyc123 commented Jul 22, 2020

prietyc123 commented Jul 23, 2020 • edited Loading

amitkrout Jul 23, 2020 • edited Loading

Choose a reason for hiding this comment

prietyc123 Jul 23, 2020

Choose a reason for hiding this comment

amitkrout Jul 23, 2020 • edited Loading

Choose a reason for hiding this comment

prietyc123 Jul 23, 2020

Choose a reason for hiding this comment

prietyc123 commented Jul 23, 2020

petr-muller commented Jul 23, 2020

openshift-ci-robot commented Jul 23, 2020 • edited Loading

prietyc123 commented Jul 23, 2020

amitkrout left a comment

Choose a reason for hiding this comment

mohammedzee1000 left a comment

Choose a reason for hiding this comment

girishramnani commented Jul 23, 2020

mik-dass commented Jul 23, 2020

openshift-ci-robot commented Jul 23, 2020

openshift-ci-robot commented Jul 23, 2020

prietyc123 commented Jun 2, 2020 •

edited

Loading

prietyc123 commented Jul 23, 2020 •

edited

Loading

amitkrout Jul 23, 2020 •

edited

Loading

amitkrout Jul 23, 2020 •

edited

Loading

openshift-ci-robot commented Jul 23, 2020 •

edited

Loading