Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3377 adding odo devfile support test #4179

Merged
merged 6 commits into from
Nov 20, 2020
Merged

#3377 adding odo devfile support test #4179

merged 6 commits into from
Nov 20, 2020

Conversation

rnapoles-rh
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind feature

What does does this PR do / why we need it:
Adds end-to-end tests for the devfile debug feature

Which issue(s) this PR fixes:

Fixes #3377

PR acceptance criteria:

  • end-to-end tests

How to test changes / Special notes to the reviewer:
ginkgo -randomizeAllSpecs -slowSpecThreshold=120 -timeout 7200s -nodes=2 -focus="odo devfile support tests" tests/e2escenarios

girishramnani
girishramnani reviewed Nov 2, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@girishramnani
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 2, 2020
@codecov
Copy link

codecov bot commented Nov 3, 2020 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@98d7308). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4179   +/-   ##
=========================================
  Coverage          ?   42.57%           
=========================================
  Files             ?      156           
  Lines             ?    13258           
  Branches          ?        0           
=========================================
  Hits              ?     5645           
  Misses            ?     7012           
  Partials          ?      601
Impacted Files Coverage Δ
pkg/odo/util/pushtarget/pushtarget.go 78.57% <0.00%> (ø)
pkg/devfile/parser/data/common/command_helper.go 73.68% <0.00%> (ø)
pkg/testingutil/pods.go 0.00% <0.00%> (ø)
pkg/project/labels.go 0.00% <0.00%> (ø)
pkg/odo/cli/env/view.go 0.00% <0.00%> (ø)
pkg/odo/cli/service/list.go 0.00% <0.00%> (ø)
pkg/component/devfile_component.go 0.00% <0.00%> (ø)
pkg/component/pushed_component.go 57.69% <0.00%> (ø)
pkg/secret/secret.go 90.90% <0.00%> (ø)
pkg/lclient/containers.go 68.29% <0.00%> (ø)
... and 146 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98d7308...97efaf0. Read the comment docs.

prietyc123
prietyc123 suggested changes Nov 3, 2020
View reviewed changes
tests/e2escenarios/e2e_devfile_test.go Show resolved Hide resolved
tests/e2escenarios/e2e_devfile_test.go Outdated Show resolved Hide resolved
tests/e2escenarios/e2e_devfile_test.go Outdated Show resolved Hide resolved
tests/e2escenarios/e2e_devfile_test.go Outdated Show resolved Hide resolved
prietyc123
prietyc123 suggested changes Nov 5, 2020
View reviewed changes
tests/e2escenarios/e2e_devfile_test.go Outdated Show resolved Hide resolved
tests/e2escenarios/e2e_devfile_test.go Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@rnapoles-rh
Copy link
Contributor Author

/retest

@prietyc123
Copy link
Contributor

Thanks @rnapoles-rh for addressing the comments.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 16, 2020
@rnapoles-rh
Copy link
Contributor Author

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9200a7f into redhat-developer:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girishramnani girishramnani girishramnani left review comments

@adisky adisky Awaiting requested review from adisky

@prietyc123 prietyc123 Awaiting requested review from prietyc123

Assignees

@prietyc123 prietyc123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add debug commands to odo devfile registry
6 participants
@rnapoles-rh @girishramnani @openshift-ci-robot @prietyc123 @openshift-bot @openshift-merge-robot