Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moves route related code from occlient.go to a new file #4213

Merged
merged 2 commits into from
Nov 25, 2020
Merged

Moves route related code from occlient.go to a new file #4213

merged 2 commits into from
Nov 25, 2020

Conversation

mik-dass
Copy link
Contributor

What type of PR is this?

/kind cleanup
/kind code-refactoring

What does does this PR do / why we need it:

Moves route related code from occlient.go to a new file. It also adds more tests.

Which issue(s) this PR fixes:

Fixes part of #4093

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

  • Tests should pass.

@mik-dass mik-dass changed the title Moves route related code from occlient.go to a new file and adds more… Moves route related code from occlient.go to a new file Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 12, 2020 •
edited

Codecov Report

Merging #4213 (d47a851) into master (0dea26a) will increase coverage by 0.07%.
The diff coverage is 67.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4213      +/-   ##
==========================================
+ Coverage   42.56%   42.64%   +0.07%     
==========================================
  Files         156      157       +1     
  Lines       13266    13265       -1     
==========================================
+ Hits         5647     5657      +10     
+ Misses       7017     7004      -13     
- Partials      602      604       +2
Impacted Files Coverage Δ
pkg/occlient/occlient.go 48.12% <ø> (+0.25%) ⬆️
pkg/occlient/routes.go 67.64% <67.64%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809462a...a77fac6. Read the comment docs.

adisky
adisky reviewed Nov 17, 2020
View reviewed changes
Copy link
Contributor

@adisky adisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 17, 2020
dharmit
dharmit suggested changes Nov 17, 2020
View reviewed changes
pkg/occlient/routes.go Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 17, 2020
@dharmit dharmit mentioned this pull request Nov 17, 2020
Merged
4 tasks
dharmit
dharmit approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mik-dass Thanks for addressing the PR feedback. 👍

Adding both labels since it was my review that removed @adisky's lgtm.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 17, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 17, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@prietyc123
Copy link
Contributor

@mik-dass could you please rebase this pr.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 18, 2020
@mik-dass
Copy link
Contributor Author

@mik-dass could you please rebase this pr.

Done

@adisky
Copy link
Contributor

adisky commented Nov 19, 2020

/retest

@mik-dass mik-dass force-pushed the client-route-refator branch 3 times, most recently from 28f465d to 052d595 Compare November 24, 2020 10:44
@adisky
Copy link
Contributor

adisky commented Nov 24, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 24, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 24, 2020
@kadel
Copy link
Member

kadel commented Nov 24, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 24, 2020
@openshift-merge-robot openshift-merge-robot merged commit d463a6a into redhat-developer:master Nov 25, 2020
@mik-dass mik-dass deleted the client-route-refator branch November 25, 2020 02:43
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisky adisky adisky left review comments

@dharmit dharmit dharmit approved these changes

@mohammedzee1000 mohammedzee1000 Awaiting requested review from mohammedzee1000

@prietyc123 prietyc123 Awaiting requested review from prietyc123

Assignees

@kadel kadel

@dharmit dharmit

@adisky adisky

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@mik-dass @openshift-ci-robot @openshift-bot @prietyc123 @adisky @kadel @dharmit @rm3l @openshift-merge-robot