-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use Service Binding Operator #5113
Do not use Service Binding Operator #5113
Conversation
@@ -25,7 +25,8 @@ const ( | |||
|
|||
// IsServiceBindingSupported checks if resource of type service binding request present on the cluster | |||
func (c *Client) IsServiceBindingSupported() (bool, error) { | |||
return c.IsResourceSupported("binding.operators.coreos.com", "v1alpha1", "servicebindings") | |||
return false, nil | |||
// return c.IsResourceSupported("binding.operators.coreos.com", "v1alpha1", "servicebindings") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be good to mention https://github.com/openshift/odo/issues/5084
in the comment to make anyone who is reading code in future understand why is this line commented out.
b0d2acf
to
c0967f9
Compare
/test psi-kubernetes-integration-e2e
|
2e86719
to
f8e2c67
Compare
/test psi-kubernetes-integration-e2e
|
/test unit |
@feloy: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
5f90713
to
aba7f2d
Compare
aba7f2d
to
cb48670
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What does this PR do / why we need it:
This PR:
Which issue(s) this PR fixes:
Fixes #5084
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer: