Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use Service Binding Operator #5113

Merged
merged 4 commits into from
Oct 5, 2021
Merged

Do not use Service Binding Operator #5113

merged 4 commits into from
Oct 5, 2021

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Oct 4, 2021 •
edited

What type of PR is this?
/kind feature

What does this PR do / why we need it:

This PR:

  • does not detect the installed Servivce Binding Operator and uses the Service Binding Library in any case.
  • removes the script to install the SBO in the cluster
  • disable integration tests relative to SBO usage

Which issue(s) this PR fixes:

Fixes #5084

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Oct 4, 2021
kadel
kadel reviewed Oct 4, 2021
View reviewed changes
pkg/kclient/operators.go
@@ -25,7 +25,8 @@ const (

// IsServiceBindingSupported checks if resource of type service binding request present on the cluster
func (c *Client) IsServiceBindingSupported() (bool, error) {
return c.IsResourceSupported("binding.operators.coreos.com", "v1alpha1", "servicebindings")
return false, nil
// return c.IsResourceSupported("binding.operators.coreos.com", "v1alpha1", "servicebindings")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to mention https://github.com/openshift/odo/issues/5084 in the comment to make anyone who is reading code in future understand why is this line commented out.

@feloy feloy changed the title Do not use Service Binding Operator WIP: Do not use Service Binding Operator Oct 4, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Oct 4, 2021
@feloy
Copy link
Contributor Author

feloy commented Oct 4, 2021

/test psi-kubernetes-integration-e2e

 Get "https://registry.stage.devfile.io/index": connection error: PROTOCOL_ERROR

@feloy
Copy link
Contributor Author

feloy commented Oct 5, 2021

/test psi-kubernetes-integration-e2e

 failed after 3m56s.

@feloy
Copy link
Contributor Author

feloy commented Oct 5, 2021

/test unit

@openshift-ci
Copy link

openshift-ci bot commented Oct 5, 2021 •
edited

@feloy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/psi-k8s-ibmc-integration-e2e aba7f2d link false /test psi-k8s-ibmc-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@feloy feloy force-pushed the feature-5084/sbo-library branch 2 times, most recently from 5f90713 to aba7f2d Compare October 5, 2021 07:39
@feloy feloy changed the title WIP: Do not use Service Binding Operator Do not use Service Binding Operator Oct 5, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Oct 5, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kadel
Copy link
Member

kadel commented Oct 5, 2021

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 5, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Oct 5, 2021
@openshift-merge-robot openshift-merge-robot merged commit 0be3021 into redhat-developer:main Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadel kadel kadel left review comments

@dharmit dharmit dharmit approved these changes

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@kadel kadel

@dharmit dharmit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

odo link flow broken on latest SBO 0.10.
4 participants
@feloy @kadel @dharmit @openshift-merge-robot