Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overlay: Disable zincati.service via dropin #24

Merged
merged 1 commit into from Dec 4, 2020
Merged

overlay: Disable zincati.service via dropin #24

merged 1 commit into from Dec 4, 2020

Conversation

LorbusChris
Copy link
Member

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2020
@LorbusChris LorbusChris mentioned this pull request Dec 4, 2020
Closed
@LorbusChris
Copy link
Member Author

/retest

1 similar comment
@LorbusChris
Copy link
Member Author

/retest

@vrutkovs
Copy link
Member

vrutkovs commented Dec 4, 2020

/hold

See okd-project/okd#215 (comment)

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2020
@LorbusChris
Copy link
Member Author

updated, @vrutkovs PTAL
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2020
@vrutkovs
Copy link
Member

vrutkovs commented Dec 4, 2020

/lgtm

@vrutkovs
Copy link
Member

vrutkovs commented Dec 4, 2020

/cherrypick release-4.6

@openshift-cherrypick-robot
Copy link

@vrutkovs: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2020
@openshift-merge-robot openshift-merge-robot merged commit 73ab66b into openshift:master Dec 4, 2020
@openshift-cherrypick-robot
Copy link

@vrutkovs: new pull request created: #30

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

Assignees

@vrutkovs vrutkovs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid mode for zincati configuration on bootstrap
5 participants
@LorbusChris @openshift-ci-robot @vrutkovs @openshift-cherrypick-robot @openshift-merge-robot