Skip to content

Commit

Permalink
Removing run_once usage on include_tasks
Browse files Browse the repository at this point in the history
Previously, run_once (and several other options) were silently ignored on include_tasks
and effectively did nothing. As of 2.7/2.8 these invalid options will now raise errors,
so they must be removed.

This was tested against an install of 3.11 originally, so there may be others that were
added after that release.
  • Loading branch information
jimi-c committed Oct 25, 2018
1 parent 80e7682 commit 58c3649
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion roles/kuryr/tasks/master.yaml
@@ -1,7 +1,6 @@
---
- name: Perform OpenShift ServiceAccount config
include_tasks: serviceaccount.yaml
run_once: true

- name: Create kuryr manifests tempdir
command: mktemp -d
Expand Down
1 change: 0 additions & 1 deletion roles/openshift_default_storage_class/tasks/main.yml
Expand Up @@ -12,4 +12,3 @@

- when: openshift_cloudprovider_kind == 'azure'
include_tasks: azure.yml
run_once: true
1 change: 0 additions & 1 deletion roles/openshift_hosted/tasks/registry.yml
Expand Up @@ -65,7 +65,6 @@
clusterip: '{{ openshift_hosted_registry_clusterip | default(omit) }}'

- include_tasks: secure.yml
run_once: true
when:
- not (openshift_docker_hosted_registry_insecure | default(False)) | bool

Expand Down

0 comments on commit 58c3649

Please sign in to comment.