Skip to content

Commit

Permalink
Merge pull request #5020 from jsanda/prometheus-endpoint-config
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue.

Prometheus endpoint config for hawkular-metrics and cassandra

Prometheus endpoints are exposed in hawkular-metrics and in cassandra by default. This PR adds options to disable them.
  • Loading branch information
openshift-merge-robot committed Sep 29, 2017
2 parents bf61775 + b9314a0 commit 615e542
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 0 deletions.
3 changes: 3 additions & 0 deletions roles/openshift_metrics/defaults/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,6 @@ openshift_metrics_cassandra_pvc_access: "{{ openshift_metrics_storage_access_mod
openshift_metrics_hawkular_user_write_access: False

openshift_metrics_heapster_allowed_users: system:master-proxy

openshift_metrics_cassandra_enable_prometheus_endpoint: True
openshift_metrics_hawkular_enable_prometheus_endpoint: True
2 changes: 2 additions & 0 deletions roles/openshift_metrics/templates/hawkular_cassandra_rc.j2
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ spec:
value: "/cassandra_data"
- name: JVM_OPTS
value: "-Dcassandra.commitlog.ignorereplayerrors=true"
- name: ENABLE_PROMETHEUS_ENDPOINT
value: "{{ openshift_metrics_cassandra_enable_prometheus_endpoint }}"
- name: TRUSTSTORE_NODES_AUTHORITIES
value: "/hawkular-cassandra-certs/tls.peer.truststore.crt"
- name: TRUSTSTORE_CLIENT_AUTHORITIES
Expand Down
3 changes: 3 additions & 0 deletions roles/openshift_metrics/templates/hawkular_metrics_rc.j2
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ spec:
- "-Dcom.datastax.driver.FORCE_NIO=true"
- "-DKUBERNETES_MASTER_URL={{openshift_metrics_master_url}}"
- "-DUSER_WRITE_ACCESS={{openshift_metrics_hawkular_user_write_access}}"
- "-Dhawkular.metrics.jmx-reporting-enabled"
env:
- name: POD_NAMESPACE
valueFrom:
Expand All @@ -66,6 +67,8 @@ spec:
value: "{{ 17 | oo_random_word }}"
- name: TRUSTSTORE_AUTHORITIES
value: "/hawkular-metrics-certs/tls.truststore.crt"
- name: ENABLE_PROMETHEUS_ENDPOINT
value: "{{ openshift_metrics_hawkular_enable_prometheus_endpoint }}"
- name: OPENSHIFT_KUBE_PING_NAMESPACE
valueFrom:
fieldRef:
Expand Down

0 comments on commit 615e542

Please sign in to comment.