Playbook failed with storage class not defined

[smarterclayton]

The origin gce builds are broken as of last night https://ci.openshift.redhat.com/jenkins/job/zz_origin_gce_image/261/

TASK [openshift_default_storage_class : Ensure storageclass object] ************
task path: /usr/share/ansible/openshift-ansible/roles/openshift_default_storage_class/tasks/main.yml:3
Saturday 10 June 2017  00:29:35 +0000 (0:00:00.296)       0:17:21.110 ********* 
fatal: [ci-primg261-ig-m-3ghd]: FAILED! => {
    "failed": true, 
    "msg": "the field 'args' has an invalid value, which appears to include a variable that is undefined. The error was: {{ openshift_storageclass_defaults[openshift_cloudprovider_kind]['provisioner'] }}: 'dict object' has no attribute u'gce'\n\nThe error appears to have been in '/usr/share/ansible/openshift-ansible/roles/openshift_default_storage_class/tasks/main.yml': line 3, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n# Install default storage classes in GCE & AWS\n- name: Ensure storageclass object\n  ^ here\n"
}

NO MORE HOSTS LEFT *************************************************************

PLAY RECAP *********************************************************************
ci-primg261-ig-m-3ghd      : ok=602  changed=173  unreachable=0    failed=1   
ci-primg261-ig-n-4fs8      : ok=222  changed=72   unreachable=0    failed=0   
ci-primg261-ig-n-b9x9      : ok=222  changed=72   unreachable=0    failed=0   
ci-primg261-ig-n-ml9r      : ok=222  changed=72   unreachable=0    failed=0   
localhost                  : ok=20   changed=7    unreachable=0    failed=0   

Saturday 10 June 2017  00:29:35 +0000 (0:00:00.024)       0:17:21.134 ********* 
=============================================================================== 
provision : Provision GCE resources ----------------------------------- 214.84s
/usr/share/ansible/openshift-ansible-gce/playbooks/roles/provision/tasks/main.yaml:20 
openshift_hosted : wait for deploy ------------------------------------- 30.07s
/usr/share/ansible/openshift-ansible/roles/openshift_hosted/tasks/router/router.yml:95 
openshift_common : Install the base package for versioning ------------- 21.41s
/usr/share/ansible/openshift-ansible/roles/openshift_common/tasks/main.yml:61 -
openshift_facts : Ensure various deps are installed -------------------- 18.10s
/usr/share/ansible/openshift-ansible/roles/openshift_facts/tasks/main.yml:59 --
openshift_common : Install the base package for versioning ------------- 17.13s
/usr/share/ansible/openshift-ansible/roles/openshift_common/tasks/main.yml:61 -
openshift_facts : Ensure various deps are installed -------------------- 16.88s
/usr/share/ansible/openshift-ansible/roles/openshift_facts/tasks/main.yml:59 --
master-http-proxy : install haproxy ------------------------------------ 16.72s
/usr/share/ansible/openshift-ansible-gce/playbooks/roles/master-http-proxy/tasks/main.yaml:8 
openshift_facts : Ensure various deps are installed -------------------- 14.28s
/usr/share/ansible/openshift-ansible/roles/openshift_facts/tasks/main.yml:59 --
openshift_node : Install Ceph storage plugin dependencies -------------- 11.73s
/usr/share/ansible/openshift-ansible/roles/openshift_node/tasks/storage_plugins/ceph.yml:2 
/usr/share/ansible/openshift-ansible/roles/os_firewall : need to pause here, otherwise the iptables service starting can sometimes cause ssh to fail -- 10.08s
/usr/share/ansible/openshift-ansible/roles/os_firewall/tasks/firewall/iptables.yml:33 
openshift_node : Install Node package ----------------------------------- 7.57s
/usr/share/ansible/openshift-ansible/roles/openshift_node/tasks/main.yml:71 ---
openshift_hosted : Create OpenShift router ------------------------------ 7.07s
/usr/share/ansible/openshift-ansible/roles/openshift_hosted/tasks/router/router.yml:75 
openshift_manageiq : Configure role/user permissions -------------------- 6.92s
/usr/share/ansible/openshift-ansible/roles/openshift_manageiq/tasks/main.yaml:43 
dynamic-inventory : Templatize environment script ----------------------- 6.44s
/usr/share/ansible/openshift-ansible-gce/playbooks/roles/dynamic-inventory/tasks/main.yaml:4 
etcd_server_certificates : Install etcd --------------------------------- 5.50s
/usr/share/ansible/openshift-ansible/roles/etcd_server_certificates/tasks/main.yml:2 
openshift_node : Install sdn-ovs package -------------------------------- 5.33s
/usr/share/ansible/openshift-ansible/roles/openshift_node/tasks/main.yml:89 ---
openshift_excluder : Install openshift excluder ------------------------- 5.07s
/usr/share/ansible/openshift-ansible/roles/openshift_excluder/tasks/install.yml:9 
openshift_master : Create master config --------------------------------- 5.02s
/usr/share/ansible/openshift-ansible/roles/openshift_master/tasks/main.yml:154 
openshift_master : Create the scheduler config -------------------------- 4.90s
/usr/share/ansible/openshift-ansible/roles/openshift_master/tasks/main.yml:64 -
openshift_node : Install GlusterFS storage plugin dependencies ---------- 4.73s
/usr/share/ansible/openshift-ansible/roles/openshift_node/tasks/storage_plugins/glusterfs.yml:2 

Failure summary:

  1. Host:     ci-primg261-ig-m-3ghd
     Play:     Create Hosted Resources
     Task:     openshift_default_storage_class : Ensure storageclass object
     Message:  the field 'args' has an invalid value, which appears to include a variable that is undefined. The error was: {{ openshift_storageclass_defaults[openshift_cloudprovider_kind]['provisioner'] }}: 'dict object' has no attribute u'gce'
               
               The error appears to have been in '/usr/share/ansible/openshift-ansible/roles/openshift_default_storage_class/tasks/main.yml': line 3, column 3, but may
               be elsewhere in the file depending on the exact syntax problem.
               
               The offending line appears to be:
               
               # Install default storage classes in GCE & AWS
               - name: Ensure storageclass object
                 ^ here
               

[smarterclayton]

The historical value we use for openshift_cloudprovider_kind on GCE is gce, not gcp which is what is in these files.

[smarterclayton]

Looks like @gnufied was the last one in this code

[gnufied]

Pushing a fix.