Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openshift_prometheus: don't try to install node exporter when uninsta… #10225

Merged
merged 1 commit into from Sep 26, 2018
Merged

openshift_prometheus: don't try to install node exporter when uninsta… #10225

merged 1 commit into from Sep 26, 2018

Conversation

pgier
Copy link
Contributor

@pgier pgier commented Sep 25, 2018

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 25, 2018
@pgier
Copy link
Contributor Author

pgier commented Sep 26, 2018

/cherrypick release-3.9

@openshift-cherrypick-robot
Copy link

@pgier: once the present PR merges, I will cherry-pick it on top of release-3.9 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pgier
Copy link
Contributor Author

pgier commented Sep 26, 2018

/assign @vrutkovs

vrutkovs
vrutkovs approved these changes Sep 26, 2018
View reviewed changes
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pgier, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@pgier
Copy link
Contributor Author

pgier commented Sep 26, 2018

/test gcp

@openshift-merge-robot openshift-merge-robot merged commit bb787b0 into openshift:release-3.10 Sep 26, 2018
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 26, 2018
Merged
@openshift-cherrypick-robot
Copy link

@pgier: new pull request created: #10240

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrutkovs vrutkovs vrutkovs approved these changes

@zgalor zgalor Awaiting requested review from zgalor

Assignees

@vrutkovs vrutkovs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pgier @openshift-cherrypick-robot @openshift-ci-robot @openshift-bot @vrutkovs @openshift-merge-robot