[release-3.9] Re-apply tuned profile during upgrade

[franckgr]

During upgrade from 3.7 to 3.9 tuned-profiles-atomic-openshift-node rpm is removed and all tuned profiles.
Tuned role is not applied during an upgrade but during a fresh install. So tuned profiles are missing after an upgrade

bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1626558

[papr-bot]

Can one of the admins verify this patch?
I understand the following commands:

• bot, add author to whitelist
• bot, test pull request
• bot, test pull request once

[sdodson]

Rather than doing this in a completely separate play add it as another post_task after line 59.

[sdodson]

I think this would be better as an additional task at

openshift-ansible/playbooks/openshift-master/private/upgrade.yml

Line 347 in 6b4ecfa

openshift_manage_node_is_master: true

rather than a new play.

[sdodson]

/ok-to-test

[franckgr]

ci/openshift-jenkins/gcp — Jenkins job failed.
Doesn't seems to be relevant to tuned modification

[michaelgugino]

/test gcp

[michaelgugino]

/lgtm

[michaelgugino]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: franckgr, michaelgugino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[michaelgugino]

/cherrypick release-3.10

[openshift-cherrypick-robot]

@michaelgugino: once the present PR merges, I will cherry-pick it on top of release-3.10 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[michaelgugino]

/cherrypick release-3.11

[openshift-cherrypick-robot]

@michaelgugino: once the present PR merges, I will cherry-pick it on top of release-3.11 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@michaelgugino: #10266 failed to apply on top of branch "release-3.10":

Applying: move tuned role from a separated play to a post task in upgrade_nodes.yml
Applying: move tuned role from post_control_plane.yml to an additional task in upgrade.yml
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	playbooks/common/openshift-cluster/upgrades/post_control_plane.yml
M	playbooks/openshift-master/private/upgrade.yml
Falling back to patching base and 3-way merge...
Auto-merging playbooks/openshift-master/private/upgrade.yml
CONFLICT (content): Merge conflict in playbooks/openshift-master/private/upgrade.yml
Auto-merging playbooks/common/openshift-cluster/upgrades/post_control_plane.yml
Patch failed at 0003 move tuned role from post_control_plane.yml to an additional task in upgrade.yml

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@michaelgugino: #10266 failed to apply on top of branch "release-3.11":

Applying: move tuned role from a separated play to a post task in upgrade_nodes.yml
Applying: move tuned role from post_control_plane.yml to an additional task in upgrade.yml
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	playbooks/common/openshift-cluster/upgrades/post_control_plane.yml
M	playbooks/openshift-master/private/upgrade.yml
Falling back to patching base and 3-way merge...
Auto-merging playbooks/openshift-master/private/upgrade.yml
CONFLICT (content): Merge conflict in playbooks/openshift-master/private/upgrade.yml
Auto-merging playbooks/common/openshift-cluster/upgrades/post_control_plane.yml
Patch failed at 0003 move tuned role from post_control_plane.yml to an additional task in upgrade.yml

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[michaelgugino]

@franckgr would you be willing to cherrypick this to master, 3.11, and 3.10?

This way, anyone that has already hit this and not noticed will be covered in the future.

[openshift-ci-robot]

@franckgr: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/gcp	ae57c0c	link	/test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.