Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup correct permissions for etcd config dir, fixes #10289 #10291

Closed
wants to merge 1 commit into from

Conversation

morsik
Copy link

@morsik morsik commented Oct 2, 2018

See #10289

Putting this into master branch. Will need to backport that to release-3.11 and release-3.10 too.

After changing this and rerunning redeploy_certificates my cluster is back again.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: morsik
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: michaelgugino

If they are not already assigned, you can assign the PR to them by writing /assign @michaelgugino in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 2, 2018
@openshift-ci-robot
Copy link

Hi @morsik. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 2, 2018
@morsik morsik changed the title Setup correct permissiosn for etcd config dir, fixes #10289 Setup correct permissions for etcd config dir, fixes #10289 Oct 2, 2018
@papr-bot
Copy link

papr-bot commented Oct 2, 2018

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@@ -145,6 +145,8 @@
unarchive:
src: "/tmp/{{ inventory_hostname }}/{{ etcd_generated_certs_dir }}/{{ etcd_cert_subdir }}.tgz"
dest: "{{ etcd_cert_config_dir }}"
owner: etcd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it necessary? Tarball should preserve permissions set on etcd_ca_host

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You tell me ;)
Without this it restores file owner/group with root:root which makes etcd fail to read it's configuration.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does etcd_ca_host has these set with root:root? What's you config - standalone etcd or static pods?

Copy link
Author

@morsik morsik Oct 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vrutkovs: I tried manually set etcd:etcd (using chown -R etcd:etcd /etc/etcd) but Ansible later sets it to root:root anyway with this task. I tried also reinstalling etcd.

This is fresh cluster installed yestarday, and yestarday I issued redeploy_certificates which broke whole cluster cause of this problem.

@vrutkovs
Copy link
Member

Master branch is closed! A major refactor is ongoing in devel-40. Changes for 3.x should be made directly to the latest release branch they're relevant to and backported from there.

@vrutkovs vrutkovs closed this Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants