refactoring #10458
refactoring #10458
Conversation
refactoring without changing functionality
openshift-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bilalcaliskan If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
needs-ok-to-test
|
Hi @bilalcaliskan. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Can one of the admins verify this patch?
|
| echo "Validating lib_openshift..." | ||
| ./roles/lib_openshift/src/generate.py --verify | ||
| if [ "${?}" -ne "0" ]; then | ||
| if [ $? != 0 ] |
There was a problem hiding this comment.
I don't think we want tabs here
| echo "Validating lib_openshift..." | ||
| ./roles/lib_openshift/src/generate.py --verify | ||
| if [ "${?}" -ne "0" ]; then | ||
| if [ $? != 0 ] |
There was a problem hiding this comment.
I don't think we want tabs here
|
Does this make the script pass tools like shellcheck? I'm only in favor of refactoring of this nature if we're doing so in order to adhere to a decently defined spec. |
|
Master branch is closed! A major refactor is ongoing in devel-40. Changes for 3.x should be made directly to the latest release branch they're relevant to and backported from there. |
refactoring without changing functionality