Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leading spaces at openstack heat template #10522

Closed
wants to merge 1 commit into from
Closed

Remove leading spaces at openstack heat template #10522

wants to merge 1 commit into from

Conversation

rbo
Copy link
Member

@rbo rbo commented Oct 25, 2018

Hi everyone,

with the leading spaces the resulting structure is getting wrong, the cns-secgrp is too far engaged.

Thanks & Regards
Robert

With the leading spaces the resulting structure is getting wrong, the
cns-secgrp is too far engaged.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 25, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rbo
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tomassedovic

If they are not already assigned, you can assign the PR to them by writing /assign @tomassedovic in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

Hi @rbo. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 25, 2018
@papr-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@tzumainn
Copy link
Contributor

Hi - thanks for the PR! I'm not 100% sure that the indentation actually is wrong, however. If you look at the two endifs at the end of the cns-secgp section, the first one matches the original indent that checks if openshift_openstack_num_cns > 0. The second endif matches this:

{% if openshift_openstack_flat_secgrp|default(False)|bool %}

@vrutkovs
Copy link
Member

Master branch is closed! A major refactor is ongoing in devel-40. Changes for 3.x should be made directly to the latest release branch they're relevant to and backported from there.

@vrutkovs vrutkovs closed this Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants