Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1633506: Possibility to define nodeSelector for hawkular-metrics-schema job #10526

Merged

Conversation

jmartisk
Copy link

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 26, 2018
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 26, 2018
@papr-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@vrutkovs
Copy link
Member

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 26, 2018
@jmartisk
Copy link
Author

jmartisk commented Nov 5, 2018

/retest

@mtnbikenc
Copy link
Member

This PR has become stale and the bug referenced has been closed deferred. Please reopen this PR if the change is still required.

@mtnbikenc mtnbikenc closed this Nov 22, 2019
@ghost
Copy link

ghost commented Feb 26, 2020

/reopen

@openshift-ci-robot
Copy link

@DHF-DaHernan: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmartisk
Copy link
Author

We have customers asking about this. Who could help get this reviewed and merged? @vrutkovs ?

@rubenvp8510
Copy link
Contributor

I reviewed this and looks good, unfortunately I don't have the rights for merge it.

@mtnbikenc mtnbikenc changed the title Possibility to define nodeSelector for hawkular-metrics-schema job Bug 1633506: Possibility to define nodeSelector for hawkular-metrics-schema job May 7, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 7, 2020
@openshift-ci-robot
Copy link

@jmartisk: This pull request references Bugzilla bug 1633506, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (3.11.z) matches configured target release for branch (3.11.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1633506: Possibility to define nodeSelector for hawkular-metrics-schema job

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtnbikenc
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmartisk, mtnbikenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2020
@openshift-merge-robot openshift-merge-robot merged commit 9cfe18e into openshift:release-3.11 May 7, 2020
@openshift-ci-robot
Copy link

@jmartisk: An error was encountered searching for external tracker bugs for bug 1633506 on the Bugzilla server at https://bugzilla.redhat.com:

could not parse external identifier "#10526" as pull: invalid pull identifier with 7 parts: "#10526"
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1633506: Possibility to define nodeSelector for hawkular-metrics-schema job

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtnbikenc
Copy link
Member

/bugzilla refresh

@openshift-ci-robot
Copy link

@mtnbikenc: An error was encountered searching for external tracker bugs for bug 1633506 on the Bugzilla server at https://bugzilla.redhat.com:

could not parse external identifier "#10526" as pull: invalid pull identifier with 7 parts: "#10526"
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtnbikenc
Copy link
Member

/bugzilla refresh

@openshift-ci-robot
Copy link

@mtnbikenc: All pull requests linked via external trackers have merged: openshift/openshift-ansible#10526. Bugzilla bug 1633506 has been moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmartisk jmartisk deleted the 3.11-bz-1633506 branch May 11, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants