[release-3.11] Add readiness + liveness probes for Service Catalog

[jboyd01]

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1630324

[sdodson]

/lgtm
Is there suspicion that this would alleviate some of the problems during restarts/upgrades?

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jboyd01, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• roles/openshift_service_catalog/OWNERS [jboyd01,sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jboyd01]

Is there suspicion that this would alleviate some of the problems during restarts/upgrades?

I wish. These should have been in here from the beginning, I'm unable to find a reason why they were not. In the associated PR the customer realized they were missing after hitting an issue where Catalog would become unresponsive. I'm just doing some final verification testing with these right now.

re: restart/upgrade - that is next on my list, will be starting on that this afternoon.

[sdodson]

/cherrypick release-3.10

[openshift-cherrypick-robot]

@sdodson: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-3.10 and openshift-cherrypick-robot:cherry-pick-10625-to-release-3.10"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"}

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sdodson]

Nevermind, was already picked here #10629