Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also set etcd_cert_config_dir for calico #10789

Merged
merged 1 commit into from Dec 3, 2018
Merged

Also set etcd_cert_config_dir for calico #10789

merged 1 commit into from Dec 3, 2018

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Nov 29, 2018

This was preventing initial cluster deployment from working as expected.

Additional fixes for https://bugzilla.redhat.com/show_bug.cgi?id=1644416

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2018
@sdodson
Copy link
Member Author

sdodson commented Nov 29, 2018

I still need to test scaleup flow with this change.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2018
@sdodson
Copy link
Member Author

sdodson commented Nov 29, 2018

@mgleung This fixes the deployment issue for me.

@mgleung
Copy link
Contributor

mgleung commented Nov 29, 2018

@sdodson makes sense to me. Got etcd_cert_config_dir mixed up with etcd_conf_dir.

@sdodson
Copy link
Member Author

sdodson commented Nov 29, 2018

Ok, this seems to work both for initial deployment and scaleup.

@sdodson sdodson changed the title [WIP] Also set etcd_cert_config_dir for calico Also set etcd_cert_config_dir for calico Nov 29, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2018
@sdodson
Copy link
Member Author

sdodson commented Nov 29, 2018

/cc @michaelgugino

@sdodson sdodson merged commit d96c05e into openshift:release-3.11 Dec 3, 2018
@mgleung
Copy link
Contributor

mgleung commented Dec 4, 2018

@sdodson can we get this cherry-picked into release-3.10 too?

@sdodson
Copy link
Member Author

sdodson commented Dec 4, 2018

/cherrypick release-3.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 4, 2018
Merged
@openshift-cherrypick-robot
Copy link

@sdodson: new pull request created: #10824

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

@michaelgugino michaelgugino Awaiting requested review from michaelgugino

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sdodson @openshift-ci-robot @mgleung @openshift-cherrypick-robot