glusterfs: bind-mount /dev/mapper into the glusterfs-server container #10806
Conversation
Commit f944503 removed the bind-mount for /dev as this will be setup by the container runtime automatically. However it seems that /dev/mapper is missing, prevending users to supply /dev/mapper/* device names to Heketi. It also seems possible that not all(?) LVM devices are available when a container starts. This change adds /dev/mapper as an additional bind-mount. CRI-O does prevent /dev to be bind-mounted, but subdirectories of /dev do not seem to be an issue. Updates: gluster/gluster-kubernetes#499
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
needs-ok-to-test
|
Hi @nixpanic. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Can one of the admins verify this patch?
|
|
/cherrypick release-3.10 |
|
@jarrpa: once the present PR merges, I will cherry-pick it on top of release-3.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/refresh |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nixpanic, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@nixpanic: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This is an unrelated AWS problem. merging. |
|
@jarrpa: new pull request created: #10823 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Commit f944503 removed the bind-mount for /dev as this will be setup by
the container runtime automatically. However it seems that /dev/mapper
is missing, prevending users to supply /dev/mapper/* device names to
Heketi. It also seems possible that not all(?) LVM devices are available
when a container starts.
This change adds /dev/mapper as an additional bind-mount. CRI-O does
prevent /dev to be bind-mounted, but subdirectories of /dev do not seem
to be an issue.
Updates: gluster/gluster-kubernetes#499