Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.11] Set credentials and proper hostname when updating loopback kubeconfig #11169

Merged

Conversation

rjhowe
Copy link
Contributor

@rjhowe rjhowe commented Feb 11, 2019

When a cluster is installed the username in the loopback kubeconfig
is equal to hostname of that local master. This changes the variable
to equal a value of what would originally be set.

Supersedes #10315 #10272 #10271
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1675133
#11158

When a cluster is installed the username in the loopback kubeconfig
is equal to hostname of that local master. This changes the variable
to equal a value of what would originally be set.

Supersedes openshift#10315 openshift#10272 openshift#10271
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1467775#c9
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 11, 2019
@rjhowe rjhowe changed the title Make sure that the user we expect has proper credentials set. [release-3.11] Set credentials and proper hostname when updating loopback kubeconfig Feb 11, 2019
rjhowe added a commit to rjhowe/openshift-ansible that referenced this pull request Feb 11, 2019
When a cluster is installed the username in the loopback kubeconfig
is equal to hostname of that local master. This changes the variable
to equal a value of what would originally be set.

Backports openshift#11169
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1675133
rjhowe added a commit to rjhowe/openshift-ansible that referenced this pull request Feb 11, 2019
…ack kubeconfig

Make sure that the user we expect has proper credentials set.

When a cluster is installed the username in the loopback kubeconfig
is equal to hostname of that local master. This changes the variable
to equal a value of what would originally be set.

Backports openshift#11169
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1675133
@vrutkovs
Copy link
Member

/test e2e-aws

@mtnbikenc
Copy link
Member

/retest

Copy link
Member

@mtnbikenc mtnbikenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtnbikenc, rjhowe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2019
@openshift-merge-robot openshift-merge-robot merged commit c2a7e7d into openshift:release-3.11 Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants