Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify DaemonSet Update #11320

Merged
merged 1 commit into from Mar 7, 2019
Merged

Simplify DaemonSet Update #11320

merged 1 commit into from Mar 7, 2019

Conversation

mtnbikenc
Copy link
Member

Avoid use of tempfiles and yedit which may cause parsing issues

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1683519

@mtnbikenc
Simplify DaemonSet Update
e5472ac 
Avoid use of tempfiles and yedit which may cause parsing issues
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 7, 2019
@mtnbikenc
Copy link
Member Author

/cherrypick release-3.10

@openshift-cherrypick-robot
Copy link

@mtnbikenc: once the present PR merges, I will cherry-pick it on top of release-3.10 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Mar 7, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtnbikenc, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit cdf4fc0 into openshift:release-3.11 Mar 7, 2019
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 7, 2019
Merged
@openshift-cherrypick-robot
Copy link

@mtnbikenc: new pull request created: #11324

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtnbikenc mtnbikenc deleted the fix-1683519 branch March 7, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

Assignees

@sdodson sdodson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mtnbikenc @openshift-cherrypick-robot @sdodson @openshift-ci-robot @openshift-merge-robot