Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release 3.10] Allow OpenStack persistent volumes to specify storage class #11376

Conversation

tzumainn
Copy link
Contributor

@tzumainn tzumainn commented Mar 20, 2019

By default, a default storage class is applied. This prevents OpenStack persistent volumes from matching their persistent volume claims, as the default storage class applies to the PVC but not the PV. This PR provides a mechanism for a deployer to specify the storage class for their PVs.

Cherrypick of #10948 on release-3.10

@tzumainn
Copy link
Contributor Author

cherry picked from #10948

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 20, 2019
@tomassedovic
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2019
@vrutkovs
Copy link
Member

Is this resolved in 3.11? Not sure why would this be applied to 3.10 instead of 3.11 first

@tomassedovic
Copy link
Contributor

@vrutkovs see #10948

It is indeed merged in 3.11. This is a 3.10 cherry pick.

@vrutkovs
Copy link
Member

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomassedovic, tzumainn, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2019
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0de2c3c into openshift:release-3.10 Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants