Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playbooks to regenerate TLS certificates for openshift-monitoring #11472

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Apr 8, 2019

When redeploy-certificates.yml is run openshift-monitoring pods need to have their TLS updated too.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1696198

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 8, 2019
@vrutkovs vrutkovs requested review from brancz, sdodson and mtnbikenc and removed request for ironcladlou and patrickdillon April 8, 2019 11:19
@mtnbikenc
Copy link
Member

Looks good. Withholding lgtm until monitoring review.

Copy link
Member

@sdodson sdodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@brancz
Copy link
Contributor

brancz commented Apr 8, 2019

Thanks a lot for doing this!

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, sdodson, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants