Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crio defaults to openshift_facts #11538

Merged

Conversation

jcpowermac
Copy link
Contributor

In release-3.10 and 3.11 crio defaults are
defined in roles/openshift_facts/defaults/main.yml
and are missing in release-3.9. Added

openshift_use_crio: False
openshift_use_crio_only: False

Bug 1678372 - https://bugzilla.redhat.com/show_bug.cgi?id=1678372

In release-3.10 and 3.11 crio defaults are
defined in `roles/openshift_facts/defaults/main.yml`
and are missing in release-3.9.  Added

`openshift_use_crio: False`
`openshift_use_crio_only: False`
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 23, 2019
Copy link
Member

@mtnbikenc mtnbikenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, mtnbikenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jcpowermac,mtnbikenc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f0d50ab into openshift:release-3.9 Apr 23, 2019
@jcpowermac jcpowermac deleted the missing_fact_default branch May 3, 2019 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants