Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KIECLOUD-202] - Update OpenShift catalog for RHIPS/DS 6.4.12 #11774

Merged
merged 1 commit into from
Jul 31, 2019
Merged

[KIECLOUD-202] - Update OpenShift catalog for RHIPS/DS 6.4.12 #11774

merged 1 commit into from
Jul 31, 2019

Conversation

spolti
Copy link
Contributor

@spolti spolti commented Jul 18, 2019

Signed-off-by: Filippe Spolti fspolti@redhat.com

@spolti
[KIECLOUD-202] - Update OpenShift catalog for RHIPS/DS 6.4.12
509568c 
Signed-off-by: Filippe Spolti <fspolti@redhat.com>
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 18, 2019
@openshift-ci-robot
Copy link

Hi @spolti. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spolti
Copy link
Contributor Author

spolti commented Jul 22, 2019

Hi, can this PR be merged?

vrutkovs
vrutkovs approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spolti, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2019
@vrutkovs
Copy link
Member

/retest

1 similar comment
@vrutkovs
Copy link
Member

/retest

@vrutkovs
Copy link
Member

/hold

Requires openshift/release#4533

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2019
@vrutkovs
Copy link
Member

/retest
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2019
@openshift-merge-robot openshift-merge-robot merged commit 2a30400 into openshift:release-3.11 Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrutkovs vrutkovs vrutkovs approved these changes

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@vrutkovs vrutkovs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spolti @openshift-ci-robot @vrutkovs @openshift-merge-robot