Bug 1741432: openshift-node to approve node CSRs #11847
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
size/M
|
@jstuever: An error was encountered searching for bug 1741432 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This change approves the node's bootstrap csr to enable it to join the cluster. This is required in cases where a node is being added to the cluster which was not deployed by the cluster.
|
@jstuever: This pull request references Bugzilla bug 1741432, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
jstuever
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
@jstuever: This pull request references Bugzilla bug 1741432, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstuever, mtnbikenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jstuever: All pull requests linked via external trackers have merged. Bugzilla bug 1741432 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
|
This change approves the node's bootstrap CSR to enable it to join the cluster. This is required in cases where a node is being added to the cluster which was not deployed by the cluster. Otherwise such nodes will never become ready and the playbook will fail. It also approves the node's other CSR for convenience of the end user.
They are considered approved when at lease one associated CSR exists (based on the nodes name) and
oc adm certificate approve <csr>has a return code of zero. This could lead to false positives if a CSR for this node already existed such as when a node name has been reused in the cluster. However, the bootstrap CSR was observed have always been pending in the cluster before Ansible recognises the node as having returned from reboot. Because of this, and the fact that all associated CSRs are approved with each attempt, this should have minimal impact.