Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1746926: Conditionally handle base64 encoded data for registries.conf #11871

Merged
merged 1 commit into from Aug 31, 2019
Merged

Bug 1746926: Conditionally handle base64 encoded data for registries.conf #11871

merged 1 commit into from Aug 31, 2019

Conversation

mtnbikenc
Copy link
Member

In some situations, the registries.conf data may be a base64 encoded string.

https://bugzilla.redhat.com/show_bug.cgi?id=1746926

@mtnbikenc
Conditionally handle base64 encoded data for registries.conf
fc9e3a3 
In some situations, the registries.conf data may be a base64 encoded
string.
@openshift-ci-robot
Copy link

@mtnbikenc: This pull request references Bugzilla bug 1746926, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1746926: Conditionally handle base64 encoded data for registries.conf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 29, 2019
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 29, 2019
@mtnbikenc
Copy link
Member Author

/test e2e-aws-scaleup-rhel7

vrutkovs
vrutkovs approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtnbikenc, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@vrutkovs
Copy link
Member

/hold

No package matching 'openshift-clients' found available, installed or updated

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2019
@sdodson
Copy link
Member

sdodson commented Aug 30, 2019

/retest

@mtnbikenc
Copy link
Member Author

Repos updated.
/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2019
@mtnbikenc
Copy link
Member Author

/retest

1 similar comment
@mtnbikenc
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 667a47f into openshift:master Aug 31, 2019
@openshift-ci-robot
Copy link

@mtnbikenc: An error was encountered searching for external tracker bugs for bug 1746926 on the Bugzilla server at https://bugzilla.redhat.com:

could not parse external identifier "11870" as pull: invalid pull identifier with 1 parts: "11870"
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1746926: Conditionally handle base64 encoded data for registries.conf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dollierp dollierp mentioned this pull request Sep 3, 2019
Closed
@mtnbikenc
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@mtnbikenc: An error was encountered searching for external tracker bugs for bug 1746926 on the Bugzilla server at https://bugzilla.redhat.com:

could not parse external identifier "11870" as pull: invalid pull identifier with 1 parts: "11870"
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtnbikenc mtnbikenc deleted the fix-1746926 branch September 3, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrutkovs vrutkovs vrutkovs approved these changes

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@vrutkovs vrutkovs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mtnbikenc @openshift-ci-robot @openshift-bot @vrutkovs @sdodson @openshift-merge-robot