Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1758744: Fix upgrade not respecting openshift_pkg_version #11956

Merged
merged 1 commit into from Oct 15, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion playbooks/openshift-master/private/upgrade.yml
Expand Up @@ -161,7 +161,6 @@
- name: Reconcile Cluster Roles and Cluster Role Bindings and Security Context Constraints
hosts: oo_masters_to_config
roles:
- openshift_cli
- openshift_facts
vars:
__master_shared_resource_viewer_file: "shared_resource_viewer_role.yaml"
Expand Down
1 change: 0 additions & 1 deletion roles/openshift_ca/README.md
Expand Up @@ -25,7 +25,6 @@ Dependencies
------------

* openshift_repos
* openshift_cli

Example Playbook
----------------
Expand Down
1 change: 0 additions & 1 deletion roles/openshift_ca/meta/main.yml
Expand Up @@ -13,6 +13,5 @@ galaxy_info:
- cloud
- system
dependencies:
- role: openshift_cli
- role: openshift_facts
- role: lib_utils
2 changes: 0 additions & 2 deletions roles/openshift_cli/defaults/main.yml

This file was deleted.

16 changes: 0 additions & 16 deletions roles/openshift_cli/meta/main.yml

This file was deleted.

36 changes: 0 additions & 36 deletions roles/openshift_cli/tasks/main.yml

This file was deleted.

20 changes: 20 additions & 0 deletions roles/openshift_node/tasks/install.yml
Expand Up @@ -12,3 +12,23 @@
- conntrack-tools
when:
- not openshift_is_atomic | bool

- when: openshift_is_atomic | bool
block:
- name: Pull CLI Image (docker)
docker_image:
name: "{{ openshift_cli_image }}"
when: not openshift_use_crio_only | bool

- name: Pull CLI Image (atomic)
command: >
atomic pull --storage ostree {{ system_openshift_cli_image }}
register: pull_result
changed_when: "'Pulling layer' in pull_result.stdout"
when: openshift_use_crio_only | bool

# openshift_container_binary_sync is a custom module in lib_utils
- name: Copy client binaries/symlinks out of CLI image for use on the host
openshift_container_binary_sync:
image: "{{ openshift_cli_image }}"
backend: "{{ (openshift_use_crio_only | bool) | ternary('atomic', 'docker') }}"