Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bug 1755120, when key is undefined ansible sets unicode type #12050

Merged
merged 1 commit into from Dec 12, 2019

Conversation

rjhowe
Copy link
Contributor

@rjhowe rjhowe commented Dec 12, 2019

Fix for bug 1755120, when key is undefined ansible sets variable to
python type unicode. This fix uses default filter to map undefined
to null. This results in the variable set to python type list as expected.

Fix for bug 1755120, when key is undefined ansible sets variable to
python type unicode. This fix uses default filter to map undefined
to null. This results in the variable set to python type list as expected.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 12, 2019
@patrickdillon
Copy link
Contributor

/retitle Bug 1755120: when key is undefined ansible sets unicode type

@openshift-ci-robot openshift-ci-robot changed the title Fix for bug 1755120, when key is undefined ansible sets unicode type Bug 1755120: when key is undefined ansible sets unicode type Dec 12, 2019
@openshift-ci-robot
Copy link

@rjhowe: This pull request references Bugzilla bug 1755120, which is invalid:

  • expected Bugzilla bug 1755120 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1755120: when key is undefined ansible sets unicode type

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 12, 2019
@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon, rjhowe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2019
@patrickdillon
Copy link
Contributor

/remove-label bugzilla/invalid-label

@openshift-ci-robot
Copy link

@patrickdillon: The label(s) /remove-label bugzilla/invalid-label cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga

In response to this:

/remove-label bugzilla/invalid-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Contributor

Hm I guess the bugzilla automation process is problematic for 3.x. Didn't realize that.

/retitle Fix for bug 1755120, when key is undefined ansible sets unicode type

@openshift-ci-robot openshift-ci-robot changed the title Bug 1755120: when key is undefined ansible sets unicode type Fix for bug 1755120, when key is undefined ansible sets unicode type Dec 12, 2019
@openshift-ci-robot
Copy link

@rjhowe: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Fix for bug 1755120, when key is undefined ansible sets unicode type

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 12, 2019
@openshift-merge-robot openshift-merge-robot merged commit cc9ac98 into openshift:release-3.11 Dec 12, 2019
@patrickdillon
Copy link
Contributor

/cherry-pick release-3.10

@openshift-cherrypick-robot

@patrickdillon: new pull request created: #12051

In response to this:

/cherry-pick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants