New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1832379: Remove cert expiry check during cert redeploy #12159
Bug 1832379: Remove cert expiry check during cert redeploy #12159
Conversation
When redeploying certificates, the cert expiry check provides little value because the expectation is that the certificates will be replaced. Addtionally, there are situations where certificates are in an invalid state and redploy is blocked by the check. Removing the checks will allow certificate redeploy to proceed without requiring additional inventory vars to override expiry days or invalid/missing certificates.
@mtnbikenc: This pull request references Bugzilla bug 1832379, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
e2e flakes |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstuever, mtnbikenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mtnbikenc: All pull requests linked via external trackers have merged: openshift/openshift-ansible#12159. Bugzilla bug 1832379 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When redeploying certificates, the cert expiry check provides little
value because the expectation is that the certificates will be replaced.
Addtionally, there are situations where certificates are in an invalid
state and redploy is blocked by the check. Removing the checks will
allow certificate redeploy to proceed without requiring additional
inventory vars to override expiry days or invalid/missing certificates.