Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1830158: Add support for global namespaces and removal of remote_group_id #12163

Merged
merged 1 commit into from May 20, 2020
Merged

Bug 1830158: Add support for global namespaces and removal of remote_group_id #12163

merged 1 commit into from May 20, 2020

Conversation

luis5tb
Copy link
Contributor

@luis5tb luis5tb commented May 18, 2020

Usage of remote_group_id has proven to be error prone as well as
scalability issue. This offers an option to remove its usage

@openshift-ci-robot
Copy link

@luis5tb: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Add support for global namespaces and removal of remote_group_id

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dulek
dulek suggested changes May 18, 2020
View reviewed changes
playbooks/openstack/configuration.md Outdated Show resolved Hide resolved
playbooks/openstack/configuration.md Show resolved Hide resolved
playbooks/openstack/configuration.md Outdated Show resolved Hide resolved
mahmadredhat
mahmadredhat reviewed May 18, 2020
View reviewed changes
playbooks/openstack/configuration.md
# Create the associated rules (tcp and udp):
$ openstack security group rule create --remote-ip 10.11.13.0/24 --protocol tcp
openshift-ansible-openshift.example.com-allow_from_default
$ openstack security group rule create --remote-ip 10.11.13.0/24 --protocol udp
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use:
--remote-ip $(openstack subnet show ns/NAMESPACE_NAME-subnet -c cidr -f value)

@luis5tb
Copy link
Contributor Author

luis5tb commented May 19, 2020

/test e2e-aws

@luis5tb
Copy link
Contributor Author

luis5tb commented May 19, 2020

/retest

@luis5tb luis5tb force-pushed the kuryr-global-namespaces branch 2 times, most recently from ffb6e40 to a15ca24 Compare May 19, 2020 12:13
@dulek
Copy link
Contributor

dulek commented May 19, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2020
MaysaMacedo
MaysaMacedo reviewed May 19, 2020
View reviewed changes
Copy link

@MaysaMacedo MaysaMacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question and suggestion:

playbooks/openstack/configuration.md Outdated Show resolved Hide resolved
playbooks/openstack/configuration.md Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 19, 2020
@luis5tb
Add support for global namespaces and removal of remote_group_id
5d7e486 
Usage of remote_group_id has proven to be error prone as well as
scalability issue. This offers an option to remove its usage
@luis5tb
Copy link
Contributor Author

luis5tb commented May 19, 2020

/test e2e-aws

@dulek
Copy link
Contributor

dulek commented May 20, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2020
@luis5tb
Copy link
Contributor Author

luis5tb commented May 20, 2020

/assign @tomassedovic

@luis5tb luis5tb changed the title Add support for global namespaces and removal of remote_group_id Bug 1830158: Add support for global namespaces and removal of remote_group_id May 20, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label May 20, 2020
@openshift-ci-robot
Copy link

@luis5tb: This pull request references Bugzilla bug 1830158, which is invalid:

  • expected the bug to target the "3.11.z" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1830158: Add support for global namespaces and removal of remote_group_id

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 20, 2020
@luis5tb
Copy link
Contributor Author

luis5tb commented May 20, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 20, 2020
@openshift-ci-robot
Copy link

@luis5tb: This pull request references Bugzilla bug 1830158, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (3.11.z) matches configured target release for branch (3.11.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 20, 2020
@tomassedovic
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, luis5tb, tomassedovic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2020
@openshift-merge-robot openshift-merge-robot merged commit 7df4087 into openshift:release-3.11 May 20, 2020
@openshift-ci-robot
Copy link

@luis5tb: All pull requests linked via external trackers have merged: openshift/kuryr-kubernetes#232, openshift/openshift-ansible#12163. Bugzilla bug 1830158 has been moved to the MODIFIED state.

In response to this:

Bug 1830158: Add support for global namespaces and removal of remote_group_id

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maxwelldb maxwelldb mentioned this pull request May 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaysaMacedo MaysaMacedo MaysaMacedo left review comments

@mahmadredhat mahmadredhat mahmadredhat left review comments

@dulek dulek dulek requested changes

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

@tomassedovic tomassedovic Awaiting requested review from tomassedovic

Assignees

@tomassedovic tomassedovic

@dulek dulek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@luis5tb @openshift-ci-robot @dulek @tomassedovic @MaysaMacedo @mahmadredhat @openshift-merge-robot