Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1921353: [release-3.11] Gather cluster_facts after version.yml during upgrade #12307

Merged
merged 1 commit into from Feb 9, 2021
Merged

Bug 1921353: [release-3.11] Gather cluster_facts after version.yml during upgrade #12307

merged 1 commit into from Feb 9, 2021

Conversation

mtnbikenc
Copy link
Member

cluster_facts.yml requires openshift_release to be set. If
openshift_release is not set in the inventory, cluster_facts.yml needs
to be run after openshift_release has been defined by the upgrade
playbook and the openshift_version role has been run.

@mtnbikenc
Gather cluster_facts after version.yml during upgrade
8694821 
cluster_facts.yml requires openshift_release to be set.  If
openshift_release is not set in the inventory, cluster_facts.yml needs
to be run after openshift_release has been defined by the upgrade
playbook and the openshift_version role has been run.
@openshift-ci-robot
Copy link

@mtnbikenc: This pull request references Bugzilla bug 1921353, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (3.11.z) matches configured target release for branch (3.11.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1921353: [release-3.11] Gather cluster_facts after version.yml during upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 4, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2021
@mtnbikenc
Copy link
Member Author

/uncc @vrutkovs
/cc @jstuever

@openshift-ci-robot openshift-ci-robot requested review from jstuever and removed request for vrutkovs February 5, 2021 13:57
@jstuever
Copy link
Contributor

jstuever commented Feb 8, 2021

/retest

@jstuever
Copy link
Contributor

jstuever commented Feb 8, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, mtnbikenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1094dce into openshift:release-3.11 Feb 9, 2021
@openshift-ci-robot
Copy link

@mtnbikenc: All pull requests linked via external trackers have merged:

Bugzilla bug 1921353 has been moved to the MODIFIED state.

In response to this:

Bug 1921353: [release-3.11] Gather cluster_facts after version.yml during upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtnbikenc mtnbikenc deleted the release-3.11-fix-1921353 branch February 9, 2021 15:49
@mtnbikenc mtnbikenc mentioned this pull request Apr 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@jstuever jstuever Awaiting requested review from jstuever

Assignees

@jstuever jstuever

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mtnbikenc @openshift-ci-robot @jstuever @openshift-bot @openshift-merge-robot