Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1939605: cri-o+kuryr: Switch to proper netns management … #12316

Merged
merged 1 commit into from May 24, 2021
Merged

Bug 1939605: cri-o+kuryr: Switch to proper netns management … #12316

merged 1 commit into from May 24, 2021

Conversation

dulek
Copy link
Contributor

@dulek dulek commented Mar 24, 2021 •
edited

cri-o is not complying with the CNI spec when
manage_network_ns_lifecycle isn't set to "true". This affects Kuryr SDN
so this commit enables that option when Kuryr is enabled.

As in that more reliable mode network namespaces are placed in the
standard /run/netns directory we need to mount it into kuryr-cni
container in order to be able to access the network namespaces there.
This commit does so too.

@openshift-ci-robot
Copy link

@dulek: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Kuryr: Mount host's /run/netns into kuryr-cni pod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2021
@dulek dulek changed the title Kuryr: Mount host's /run/netns into kuryr-cni pod Bug 1939605: Kuryr: Mount host's /run/netns into kuryr-cni pod Mar 24, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Mar 24, 2021
@openshift-ci-robot
Copy link

@dulek: This pull request references Bugzilla bug 1939605, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (3.11.z) matches configured target release for branch (3.11.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

In response to this:

Bug 1939605: Kuryr: Mount host's /run/netns into kuryr-cni pod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 24, 2021
@dulek
Copy link
Contributor Author

dulek commented Mar 24, 2021

/hold

I need cri-o's go ahead first.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2021
@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2021
@dulek
Copy link
Contributor Author

dulek commented Apr 2, 2021

/retest

1 similar comment
@dulek
Copy link
Contributor Author

dulek commented Apr 6, 2021

/retest

@MaysaMacedo
Copy link

just confirming, non crio installation works fine as well with the new mounting path, right?

@dulek
Copy link
Contributor Author

dulek commented Apr 6, 2021

just confirming, non crio installation works fine as well with the new mounting path, right?

Sure, I'm not removing the old mount of host's /proc.

@haircommander haircommander mentioned this pull request Apr 7, 2021
Closed
@dulek
Copy link
Contributor Author

dulek commented Apr 7, 2021

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2021
@dulek
Copy link
Contributor Author

dulek commented Apr 7, 2021

/retest

haircommander
haircommander reviewed Apr 7, 2021
View reviewed changes
roles/container_runtime/templates/crio.conf.j2
Comment on lines +118 to +120
# manage_network_ns_lifecycle determines whether we pin and remove network namespaces
# and manage their lifecycle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we put this clause inside of the if statement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, I should, that's a template.

@haircommander
Copy link
Member

one nit, non blocking, otherwise LGTM, thanks @dulek

@dulek
cri-o+kuryr: Switch to proper netns management
0b7fd47 
cri-o is not complying with the CNI spec when
manage_network_ns_lifecycle isn't set to "true". This affects Kuryr SDN
so this commit enables that option when Kuryr is enabled.

As in that more reliable mode network namespaces are placed in the
standard /run/netns directory we need to mount it into kuryr-cni
container in order to be able to access the network namespaces there.
This commit does so too.
@haircommander
Copy link
Member

/retest

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2021
@openshift-ci-robot
Copy link

@dulek: This pull request references Bugzilla bug 1939605, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (3.11.z) matches configured target release for branch (3.11.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lyman9966

In response to this:

Bug 1939605: Kuryr: Mount host's /run/netns into kuryr-cni pod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

18 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@mtnbikenc
Copy link
Member

More CI issues to investigate.
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2021
@dulek
Copy link
Contributor Author

dulek commented May 18, 2021

/retest

Just checking if it haven't fixed on it's own. @mtnbikenc: If it won't work, do you have an idea where to look for help?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2021 •
edited

@dulek: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-crio 0b7fd47 link /test e2e-gcp-crio

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mtnbikenc
Copy link
Member

Based on this line in the job, I'm wondering if there is an issue because of the warning that user "ci-test" is not found.

�[36mINFO�[0m[2021-05-18T14:00:56Z] ci-op-66nx95xj-e0b3b-master | CHANGED | rc=0 >> 
�[36mINFO�[0m[2021-05-18T14:00:56Z] cluster role "cluster-admin" added: "ci-test"Warning: User 'ci-test' not found

The three ad-hoc Ansible commands succeed, but then the oc login command never completes successfully, possibly because user ci-test does not exist. I do not know where or how user ci-test is or should be created.

@mtnbikenc
Copy link
Member

I'm still looking into ese-aws errors as I have time. I've discovered the xio.io service is offline and we depend on that for CI name resolution. I'll be testing some alternatives.

@mtnbikenc
Copy link
Member

e2e-aws should be fixed/
/retest

@mtnbikenc
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2021
@openshift-merge-robot openshift-merge-robot merged commit cce4861 into openshift:release-3.11 May 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2021

@dulek: All pull requests linked via external trackers have merged:

Bugzilla bug 1939605 has been moved to the MODIFIED state.

In response to this:

Bug 1939605: cri-o+kuryr: Switch to proper netns management …

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander haircommander left review comments

@luis5tb luis5tb Awaiting requested review from luis5tb

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

@lyman9966 lyman9966 Awaiting requested review from lyman9966

Assignees

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dulek @openshift-ci-robot @MaysaMacedo @haircommander @mtnbikenc @openshift-bot @openshift-merge-robot