Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1994172: crio: drop symlink for conmon, as it is being called from path again #12342

Merged

Conversation

haircommander
Copy link
Member

Signed-off-by: Peter Hunt pehunt@redhat.com

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Aug 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2021

@haircommander: This pull request references Bugzilla bug 1994172, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1994172: crio: drop symlink for conmon, as it is being called from path again

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 17, 2021
@haircommander
Copy link
Member Author

/bugzilla refresh

@haircommander
Copy link
Member Author

/cherry-pick release-4.8

@openshift-cherrypick-robot

@haircommander: once the present PR merges, I will cherry-pick it on top of release-4.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member Author

/cherry-pick release-4.7

@openshift-cherrypick-robot

@haircommander: once the present PR merges, I will cherry-pick it on top of release-4.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member Author

analogous to openshift/machine-config-operator#2712

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2021

@haircommander: An error was encountered querying GitHub for users with public email (schoudha@redhat.com) for bug 1994172 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2021

@haircommander: This pull request references Bugzilla bug 1994172, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

In response to this:

analogous to openshift/machine-config-operator#2712

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 17, 2021
@mtnbikenc
Copy link
Member

@haircommander , These tasks were added because of an issue with RHEL8 hosts. Support for RHEL8 was added in 4.9 so these tasks don't exist in 4.8 and 4.7.

@haircommander
Copy link
Member Author

ah I see, thanks!

@mtnbikenc
Copy link
Member

Since the RHEL8 CI jobs PR has not merged I've tested this PR manually with RHEL8 nodes. Install success.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2021
@haircommander
Copy link
Member Author

/retest

@sdodson
Copy link
Member

sdodson commented Aug 19, 2021

Does anything need to be done to remove the symlink?

@nee1esh
Copy link

nee1esh commented Aug 23, 2021

/test e2e-aws-workers-rhel7

@haircommander
Copy link
Member Author

Does anything need to be done to remove the symlink?

have we released since we introduced this? Since support was added in 4.9, only ephemeral ci clusters should have gotten it. I am not sure there are any symlinks in the wild with it. Is that correct @mtnbikenc

@mtnbikenc
Copy link
Member

Does anything need to be done to remove the symlink?

have we released since we introduced this? Since support was added in 4.9, only ephemeral ci clusters should have gotten it. I am not sure there are any symlinks in the wild with it. Is that correct @mtnbikenc

Correct, this was added for 4.9 and is not yet released.

@haircommander
Copy link
Member Author

/retest

@haircommander
Copy link
Member Author

/test e2e-aws-workers-rhel7

@mtnbikenc
Copy link
Member

/lgtm

workers-rhel7 job failures are unrelated to this PR.
/override ci/prow/e2e-aws-workers-rhel7

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2021

@mtnbikenc: Overrode contexts on behalf of mtnbikenc: ci/prow/e2e-aws-workers-rhel7

In response to this:

/lgtm

workers-rhel7 job failures are unrelated to this PR.
/override ci/prow/e2e-aws-workers-rhel7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2021
@openshift-merge-robot openshift-merge-robot merged commit b111f9c into openshift:master Aug 25, 2021
@openshift-cherrypick-robot

@haircommander: new pull request could not be created: failed to create pull request against openshift/openshift-ansible#release-4.7 from head openshift-cherrypick-robot:cherry-pick-12342-to-release-4.7: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.7 and openshift-cherrypick-robot:cherry-pick-12342-to-release-4.7"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mtnbikenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-cherrypick-robot

@haircommander: new pull request could not be created: failed to create pull request against openshift/openshift-ansible#release-4.8 from head openshift-cherrypick-robot:cherry-pick-12342-to-release-4.8: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.8 and openshift-cherrypick-robot:cherry-pick-12342-to-release-4.8"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2021

@haircommander: All pull requests linked via external trackers have merged:

Bugzilla bug 1994172 has been moved to the MODIFIED state.

In response to this:

Bug 1994172: crio: drop symlink for conmon, as it is being called from path again

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants