Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-22366: Restart the openvswitch service on [re]install #12476

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

barbacbd
Copy link
Contributor

@barbacbd barbacbd commented Jan 3, 2024

Restart the openvswitch service when installed/upgraded if it exists. This should resolve network connectivity issues during upgrades.

Restart the openvswitch service when installed/upgraded if it exists. This should resolve network
connectivity issues during upgrades.
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 3, 2024
@openshift-ci-robot
Copy link

@barbacbd: This pull request references Jira Issue OCPBUGS-22366, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Restart the openvswitch service when installed/upgraded if it exists. This should resolve network connectivity issues during upgrades.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2024
@barbacbd
Copy link
Contributor Author

barbacbd commented Jan 3, 2024

@gpei I noticed that the state of openvswitch is active (exited). This state can be observed before and after these changes so it is not introduced here. I don't think this is causing issues but systemd does not believe that there is a daemon to watch/monitor.

@barbacbd
Copy link
Contributor Author

barbacbd commented Jan 3, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 3, 2024
@openshift-ci-robot
Copy link

@barbacbd: This pull request references Jira Issue OCPBUGS-22366, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 3, 2024
@openshift-ci openshift-ci bot requested a review from gpei January 3, 2024 17:36
@barbacbd
Copy link
Contributor Author

barbacbd commented Jan 3, 2024

/test e2e-aws-workers-rhel8

@barbacbd
Copy link
Contributor Author

barbacbd commented Jan 4, 2024

It appears that the current version of kubernetes is 1.29 and crio is only 1.28 causing the failure.

@barbacbd
Copy link
Contributor Author

barbacbd commented Jan 4, 2024

/retest-required

@gpei
Copy link
Contributor

gpei commented Jan 7, 2024

It appears that the current version of kubernetes is 1.29 and crio is only 1.28 causing the failure.

Yes, we've created a Jira issue to ART team for this https://issues.redhat.com/browse/ART-8558

@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2024
Copy link
Contributor

openshift-ci bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [barbacbd,patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8ea9a41 and 2 for PR HEAD e80be9d in total

@barbacbd
Copy link
Contributor Author

/retest-required

1 similar comment
@barbacbd
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d96c87d and 1 for PR HEAD e80be9d in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c369981 and 0 for PR HEAD e80be9d in total

@openshift-ci-robot
Copy link

/hold

Revision e80be9d was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2024
@sadasu
Copy link

sadasu commented Feb 20, 2024

/retest-required

@barbacbd
Copy link
Contributor Author

/label acknowledge-critical-fixes-only

@gpei
Copy link
Contributor

gpei commented Mar 8, 2024

/test e2e-aws-workers-rhel8

@barbacbd
Copy link
Contributor Author

barbacbd commented Mar 8, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2024
Copy link
Contributor

openshift-ci bot commented Mar 8, 2024

@barbacbd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2ef36be into openshift:master Mar 8, 2024
5 checks passed
@openshift-ci-robot
Copy link

@barbacbd: Jira Issue OCPBUGS-22366: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-22366 has been moved to the MODIFIED state.

In response to this:

Restart the openvswitch service when installed/upgraded if it exists. This should resolve network connectivity issues during upgrades.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gpei
Copy link
Contributor

gpei commented Jun 4, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot

@gpei: new pull request created: #12502

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants