Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ansible-core version #12478

Closed
wants to merge 4 commits into from
Closed

Bump ansible-core version #12478

wants to merge 4 commits into from

Conversation

patrickdillon
Copy link
Contributor

Centos stream 8 contains ansible 2.16. 2.14 or older is nowhere to be found, causing CI to fail with:

Built RPMs                                      135 kB/s | 1.9 kB     00:00    
Extra Packages for Enterprise Linux 8 - x86_64   31 MB/s |  16 MB     00:00    
Extra Packages for Enterprise Linux Modular 8 - 2.0 MB/s | 733 kB     00:00    
No match for argument: ansible-core < 2.14
Error: Unable to find a match: ansible-core < 2.14

Let's try bumping to 2.16.

@openshift-ci openshift-ci bot requested a review from barbacbd February 5, 2024 21:33
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2024
barbacbd
barbacbd reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [barbacbd,patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8ea9a41 and 2 for PR HEAD 651d552 in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 5, 2024

New changes are detected. LGTM label has been removed.

barbacbd
barbacbd reviewed Feb 6, 2024
View reviewed changes
images/installer/Dockerfile Outdated
@@ -26,15 +26,16 @@ COPY images/installer/root /
RUN yum install -y epel-release 'dnf-command(config-manager)' && \
yum config-manager --enable built > /dev/null && \
yum install --setopt=tsflags=nodocs -y \
'ansible-core < 2.14' \
python38-dateutil python38-urllib3 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python38-dateutil python38-urllib3 \
python39 python39-devel python39-urllib3 \

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that python needs to be updated in order to grab a higher version of ansible-core.

images/installer/Dockerfile
python38-dateutil python38-urllib3 \
python3-pip \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python3-pip \

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

@patrickdillon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-workers-rhel8 818aff3 link true /test e2e-aws-workers-rhel8

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor Author

/close
in favor of #12479

@openshift-ci openshift-ci bot closed this Feb 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

@patrickdillon: Closed this PR.

In response to this:

/close
in favor of #12479

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbacbd barbacbd barbacbd left review comments

Assignees

@barbacbd barbacbd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patrickdillon @openshift-ci-robot @barbacbd