Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 1414625. Additional fix to run password commands on control node #3195

Merged
merged 1 commit into from Jan 27, 2017
Merged

fix 1414625. Additional fix to run password commands on control node #3195

merged 1 commit into from Jan 27, 2017

Conversation

jcantrill
Copy link
Contributor

fixes where we check for tool on control, but were still running on master

@ewolinetz @sdodson

@jcantrill jcantrill force-pushed the bz_1414625_httpd_on_control branch 2 times, most recently from 5471fdc to 23fd0f9 Compare January 26, 2017 19:26
@jcantrill
Copy link
Contributor Author

aos-ci-test

ewolinetz
ewolinetz reviewed Jan 27, 2017
View reviewed changes
roles/openshift_metrics/tasks/generate_hawkular_certificates.yaml

- include: import_jks_certs.yaml

- file: path="{{local_tmp.stdout}}" state=absent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be a local_action since we create it as a local_action

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@ewolinetz
Copy link
Contributor

one nit, otherwise LGTM

@openshift-bot
Copy link

23fd0f9 - State: success - All Test Contexts: aos-ci-jenkins/OS_unit_tests - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-2-unit-tests-778/23fd0f91b5600c0866e83b53be12fd8913be9d8f.txt

@openshift-bot
Copy link

23fd0f9 - State: success - All Test Contexts: "aos-ci-jenkins/OS_3.3_NOT_containerized, aos-ci-jenkins/OS_3.3_NOT_containerized_e2e_tests" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_NOT_containerized,OSE_VER=3.3,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster,TargetBranch=master,nodes=openshift-ansible-slave-783/23fd0f91b5600c0866e83b53be12fd8913be9d8f.txt

@openshift-bot
Copy link

23fd0f9 - State: success - All Test Contexts: "aos-ci-jenkins/OS_3.4_NOT_containerized, aos-ci-jenkins/OS_3.4_NOT_containerized_e2e_tests" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_NOT_containerized,OSE_VER=3.4,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster,TargetBranch=master,nodes=openshift-ansible-slave-783/23fd0f91b5600c0866e83b53be12fd8913be9d8f.txt

@openshift-bot
Copy link

23fd0f9 - State: success - All Test Contexts: "aos-ci-jenkins/OS_3.4_containerized, aos-ci-jenkins/OS_3.4_containerized_e2e_tests" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_containerized,OSE_VER=3.4,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster-containerized,TargetBranch=master,nodes=openshift-ansible-slave-783/23fd0f91b5600c0866e83b53be12fd8913be9d8f.txt

@openshift-bot
Copy link

23fd0f9 - State: success - All Test Contexts: "aos-ci-jenkins/OS_3.3_containerized, aos-ci-jenkins/OS_3.3_containerized_e2e_tests" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_containerized,OSE_VER=3.3,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster-containerized,TargetBranch=master,nodes=openshift-ansible-slave-783/23fd0f91b5600c0866e83b53be12fd8913be9d8f.txt

sdodson
sdodson reviewed Jan 27, 2017
View reviewed changes
Copy link
Member

@sdodson sdodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the method for ensuring passwords aren't generated on each run is to check for existence of the htpasswd or keystores on the remote hosts then only generate those locally if they don't exist?

@jcantrill
Copy link
Contributor Author

@sdodson yes

@jcantrill
Copy link
Contributor Author

aos-ci-test

@openshift-bot
Copy link

bef725c - State: success - All Test Contexts: aos-ci-jenkins/OS_unit_tests - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-2-unit-tests-786/bef725c7b04f7f0ba9fe83673024928e33b3ce2e.txt

@openshift-bot
Copy link

bef725c - State: success - All Test Contexts: "aos-ci-jenkins/OS_3.3_NOT_containerized, aos-ci-jenkins/OS_3.3_NOT_containerized_e2e_tests" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_NOT_containerized,OSE_VER=3.3,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster,TargetBranch=master,nodes=openshift-ansible-slave-791/bef725c7b04f7f0ba9fe83673024928e33b3ce2e.txt

@openshift-bot
Copy link

bef725c - State: success - All Test Contexts: "aos-ci-jenkins/OS_3.4_NOT_containerized, aos-ci-jenkins/OS_3.4_NOT_containerized_e2e_tests" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_NOT_containerized,OSE_VER=3.4,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster,TargetBranch=master,nodes=openshift-ansible-slave-791/bef725c7b04f7f0ba9fe83673024928e33b3ce2e.txt

@openshift-bot
Copy link

bef725c - State: success - All Test Contexts: "aos-ci-jenkins/OS_3.4_containerized, aos-ci-jenkins/OS_3.4_containerized_e2e_tests" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_containerized,OSE_VER=3.4,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster-containerized,TargetBranch=master,nodes=openshift-ansible-slave-791/bef725c7b04f7f0ba9fe83673024928e33b3ce2e.txt

@openshift-bot
Copy link

bef725c - State: success - All Test Contexts: "aos-ci-jenkins/OS_3.3_containerized, aos-ci-jenkins/OS_3.3_containerized_e2e_tests" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_containerized,OSE_VER=3.3,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster-containerized,TargetBranch=master,nodes=openshift-ansible-slave-791/bef725c7b04f7f0ba9fe83673024928e33b3ce2e.txt

@sdodson sdodson merged commit d1f121c into openshift:master Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewolinetz ewolinetz ewolinetz left review comments

@sdodson sdodson sdodson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcantrill @ewolinetz @openshift-bot @sdodson