New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend the excluders to containerized deployment #3607
extend the excluders to containerized deployment #3607
Conversation
aos-ci-test |
d833906 - State: success - All Test Contexts: aos-ci-jenkins/OS_unit_tests - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-2-unit-tests-1078/d83390624f1a48444ddebb98471b254f3b968bd0.txt |
I personally don't think this is the solution QE wanted. We usually don't have OCP repo for containerized deployment on RHEL. It's not happy to see installer failed when no OCP repos on RHEL for containerized installation. |
@ganhuang but that's the only location that the excluders exist and we should enforce docker exclusions. How else should we do that? The documentation actually makes no distinction between containerized and rpm based hosts as far as enabling channels. So I think it's fine to rely on content from the OCP channels. Only after finishing the host preparation does the documentation diverge for containerized versus rpm based installation. See |
d833906 - State: success - All Test Contexts: "aos-ci-jenkins/OS_3.4_NOT_containerized, aos-ci-jenkins/OS_3.4_NOT_containerized_e2e_tests" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_NOT_containerized,OSE_VER=3.4,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster,TargetBranch=master,nodes=openshift-ansible-slave-1082/d83390624f1a48444ddebb98471b254f3b968bd0.txt |
d833906 - State: success - All Test Contexts: "aos-ci-jenkins/OS_3.5_NOT_containerized, aos-ci-jenkins/OS_3.5_NOT_containerized_e2e_tests" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_NOT_containerized,OSE_VER=3.5,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster,TargetBranch=master,nodes=openshift-ansible-slave-1082/d83390624f1a48444ddebb98471b254f3b968bd0.txt |
d833906 - State: success - All Test Contexts: "aos-ci-jenkins/OS_3.5_containerized, aos-ci-jenkins/OS_3.5_containerized_e2e_tests" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_containerized,OSE_VER=3.5,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster-containerized,TargetBranch=master,nodes=openshift-ansible-slave-1082/d83390624f1a48444ddebb98471b254f3b968bd0.txt |
d833906 - State: success - All Test Contexts: "aos-ci-jenkins/OS_3.4_containerized, aos-ci-jenkins/OS_3.4_containerized_e2e_tests" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_containerized,OSE_VER=3.4,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster-containerized,TargetBranch=master,nodes=openshift-ansible-slave-1082/d83390624f1a48444ddebb98471b254f3b968bd0.txt |
@sdodson I forgot to ack that bug. I thought we have made some efforts to not use OCP channel in containerized deployment on RHEL. To make the default setting in openshift-ansible more reliable, we can leave the options to users so that they can decide if installer would install *-excluder in containerized installation on RHEL instead of failing directly if they don't have that channels subscribed. Upgrade can follow that options as well in this case. |
We did for the python-ruamel-yaml thing because we had a fall back, but I'm afraid that we're going to have more and more requirements that only exist in the OCP channels so we should become more comfortable with including them. |
the docker excluder is needed in containerized deployment as well
bug 1430700