Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend the excluders to containerized deployment #3607

Conversation

ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Mar 9, 2017

the docker excluder is needed in containerized deployment as well

bug 1430700

@ingvagabund
Copy link
Member Author

aos-ci-test

@openshift-bot
Copy link

@ingvagabund ingvagabund requested a review from sdodson March 9, 2017 13:52
@ganhuang
Copy link
Contributor

ganhuang commented Mar 9, 2017

I personally don't think this is the solution QE wanted. We usually don't have OCP repo for containerized deployment on RHEL. It's not happy to see installer failed when no OCP repos on RHEL for containerized installation.

@sdodson
Copy link
Member

sdodson commented Mar 9, 2017

@ganhuang but that's the only location that the excluders exist and we should enforce docker exclusions. How else should we do that?

The documentation actually makes no distinction between containerized and rpm based hosts as far as enabling channels. So I think it's fine to rely on content from the OCP channels. Only after finishing the host preparation does the documentation diverge for containerized versus rpm based installation.

See
https://docs.openshift.com/container-platform/3.4/install_config/install/host_preparation.html

@ingvagabund ingvagabund merged commit 39e84a4 into openshift:master Mar 9, 2017
@ingvagabund ingvagabund deleted the extend-excluders-to-containerized-ocp branch March 9, 2017 14:41
@ganhuang
Copy link
Contributor

ganhuang commented Mar 9, 2017

@sdodson I forgot to ack that bug. I thought we have made some efforts to not use OCP channel in containerized deployment on RHEL.

To make the default setting in openshift-ansible more reliable, we can leave the options to users so that they can decide if installer would install *-excluder in containerized installation on RHEL instead of failing directly if they don't have that channels subscribed. Upgrade can follow that options as well in this case.

@sdodson
Copy link
Member

sdodson commented Mar 9, 2017

@sdodson I forgot to ack that bug. I thought we have made some efforts to not use OCP channel in containerized deployment on RHEL.

We did for the python-ruamel-yaml thing because we had a fall back, but I'm afraid that we're going to have more and more requirements that only exist in the OCP channels so we should become more comfortable with including them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants