Fix templating of static service files

[mtnbikenc]

Static files should use copy: to retrieve from the files\ directory. Maybe?

ansible/ansible#18489
#4131

[ashcrow]

My internal understanding of ansible isn't strong enough to note if that would make a difference but I don't think it would hurt.

[mtnbikenc]

Appears there is a bug in Ansible. Looks in <role_name>/tasks/files instead of <role_name>/files.

Debug:

 27140 1494616290.06971: search_path:
	/home/rteague/dev/clusters/aws-c1/openshift-ansible/roles/openshift_master/tasks/files/atomic-openshift-master.service
	/home/rteague/dev/clusters/aws-c1/openshift-ansible/roles/openshift_master/tasks/atomic-openshift-master.service
	/home/rteague/dev/clusters/aws-c1/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_6/../../../../common/openshift-cluster/upgrades/v3_6/../files/atomic-openshift-master.service
	/home/rteague/dev/clusters/aws-c1/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_6/../../../../common/openshift-cluster/upgrades/v3_6/../atomic-openshift-master.service

> $ ansible --versionansible 2.3.0.0
  config file = /home/rteague/dev/clusters/aws-c1/ansible.cfg
  configured module search path = [u'/usr/lib/python2.7/site-packages/ara/plugins/modules']
  python version = 2.7.13 (default, Jan 12 2017, 17:59:37) [GCC 6.3.1 20161221 (Red Hat 6.3.1-1)]

[mtnbikenc]

Added a temporary static link for tasks/files -> ../files until I can figure out if and where this is fixed in Ansible. Confirmed the problem also exists in Ansible 2.2.2.0.

[sdodson]

@mtnbikenc Unfortunately some of these aren't static. All of the services that depend on docker have jinja templates to evaluate.

[sdodson]

The node services.

[mtnbikenc]

@sdodson Yeah, thanks for pointing that out. I'll fix the node service files. I'm still running into this problem and there has been a lot of churn on search path resolution, even recently.

ansible/ansible@ec05cd6

[mtnbikenc]

aos-ci-test

[openshift-bot]

error: aos-ci-jenkins/OS_3.6_containerized for c37fbea (logs)

[openshift-bot]

error: aos-ci-jenkins/OS_3.5_containerized for c37fbea (logs)

[openshift-bot]

error: aos-ci-jenkins/OS_3.6_NOT_containerized for c37fbea (logs)

[ashcrow]

This looks unrelated to me. Looking for a flake.

2017-05-15 16:26:30,316 - taskrunner - ERROR - Caught exception while running 'GetNodes'
Traceback (most recent call last):
  File "/home/jenkins/shiningpanda/jobs/26eaa329/virtualenvs/d41d8cd9/lib/python2.7/site-packages/taskrunner/main.py", line 144, in _run_tasks
    task.run(context)
  File "/home/jenkins/workspace/openshift-ansible-test-matrix/CONTAINERIZED/_NOT_containerized/OSE_VER/3.6/PYTHON/System-CPython-2.7/TOPOLOGY/openshift-cluster/TargetBranch/master/nodes/openshift-ansible-slave/ci-factory/tasks/get_nodes_task.py", line 280, in run
    desc = self.create_nodes(names)
  File "/home/jenkins/workspace/openshift-ansible-test-matrix/CONTAINERIZED/_NOT_containerized/OSE_VER/3.6/PYTHON/System-CPython-2.7/TOPOLOGY/openshift-cluster/TargetBranch/master/nodes/openshift-ansible-slave/ci-factory/tasks/get_nodes_task.py", line 337, in create_nodes
    vms = self._boot_nodes(names)
  File "/home/jenkins/workspace/openshift-ansible-test-matrix/CONTAINERIZED/_NOT_containerized/OSE_VER/3.6/PYTHON/System-CPython-2.7/TOPOLOGY/openshift-cluster/TargetBranch/master/nodes/openshift-ansible-slave/ci-factory/tasks/get_nodes_task.py", line 415, in _boot_nodes
    user_data=user_data)
  File "/home/jenkins/workspace/openshift-ansible-test-matrix/CONTAINERIZED/_NOT_containerized/OSE_VER/3.6/PYTHON/System-CPython-2.7/TOPOLOGY/openshift-cluster/TargetBranch/master/nodes/openshift-ansible-slave/ci-factory/tasks/nodefactory.py", line 104, in boot_node
    raise Exception('An unexpected exception has '
Exception: An unexpected exception has been encountered

[openshift-bot]

success: "aos-ci-jenkins/OS_3.5_NOT_containerized, aos-ci-jenkins/OS_3.5_NOT_containerized_e2e_tests" for c37fbea (logs)

[mtnbikenc]

aos-ci-test

[openshift-bot]

error: aos-ci-jenkins/OS_3.5_NOT_containerized for c37fbea (logs)

[openshift-bot]

error: aos-ci-jenkins/OS_3.6_containerized for c37fbea (logs)

[openshift-bot]

error: aos-ci-jenkins/OS_3.5_containerized for c37fbea (logs)

[openshift-bot]

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for c37fbea (logs)

[sdodson]

aos-ci-test

[openshift-bot]

success: "aos-ci-jenkins/OS_3.5_NOT_containerized, aos-ci-jenkins/OS_3.5_NOT_containerized_e2e_tests" for c37fbea (logs)

[openshift-bot]

success: "aos-ci-jenkins/OS_3.5_containerized, aos-ci-jenkins/OS_3.5_containerized_e2e_tests" for c37fbea (logs)

[openshift-bot]

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for c37fbea (logs)

[openshift-bot]

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for c37fbea (logs)

[mtnbikenc]

[merge]

[openshift-bot]

Evaluated for openshift ansible merge up to c37fbea

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/384/) (Base Commit: 15fd420)